Skip to content

Commit

Permalink
fix(dialog): invalid text color in dark themes
Browse files Browse the repository at this point in the history
In dark themes the dialog container will have a dark background and the text should therefore have a light text color.

Currently the text color is still dark on a dark background which causes the dialog to look bad in dark themes.
  • Loading branch information
devversion committed May 27, 2017
1 parent 12d6e96 commit cfc2e6d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/lib/dialog/_dialog-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@

@mixin mat-dialog-theme($theme) {
$background: map-get($theme, background);
$foreground: map-get($theme, foreground);

.mat-dialog-container {
background: mat-color($background, dialog);
color: mat-color($foreground, text)
}
}
2 changes: 1 addition & 1 deletion tools/gulp/packaging/build-tasks-gulp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const inlineResources = require('../../../scripts/release/inline-resources');
* @param packageName Name of the package. Needs to be similar to the directory name in `src/`.
* @param requiredPackages Required packages that will be built before building the current package.
*/
export function createPackageBuildTasks(packageName: string, requiredPackages: string[] = [], ) {
export function createPackageBuildTasks(packageName: string, requiredPackages: string[] = []) {
// To avoid refactoring of the project the package material will map to the source path `lib/`.
const packageRoot = join(SOURCE_ROOT, packageName === 'material' ? 'lib' : packageName);
const packageOut = join(DIST_ROOT, 'packages', packageName);
Expand Down

0 comments on commit cfc2e6d

Please sign in to comment.