-
Notifications
You must be signed in to change notification settings - Fork 6.8k
MatSelect accessibility rework #11083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
They're separate components but do share some code; that feature looks to be orthogonal to this. |
Hi @jelbourn , please pardon my ignorance, by orthogonal do you mean unrelated to this rework? |
Yeah, I mean this rework doesn't affect that feature one way or another. |
Are there any known workarounds to this issue while waiting on the rework? I'm thinking of trying to style an HTML Select to look similar with a floating label, etc. |
Using a native select will certainly give better a11y. |
@jelbourn Do you think there would be any value in moving the core and accessibility logic of MatSelect into a new CdkSelect component, so that MatSelect only provides the Material-specific styling on top of this? Creating a component that is functionally equivalent to native |
@benelliott It's something I'd like to do; we're still figuring out what we want the final API to look like. Once that's settled, we can figure out which parts make sense to be in the cdk. |
This comment has been minimized.
This comment has been minimized.
@jelbourn If these discussions about the API need to remain internal, that's cool. Otherwise I'd be happy to contribute if you can point me to a particular thread. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi, I have an application where the |
This comment has been minimized.
This comment has been minimized.
For what it's worth: I arrived here after our A11y scanner library threw this error in e2e.
And let's just say hopping around these issues has been confusing. But simply putting
Am I not understanding something about the bigger picture or how A11y works in general? |
This comment has been minimized.
This comment has been minimized.
@412andrewmortimer that might trick the scanner, but to verify if that helped or hurt (possible), you would need to test your app with screen readers like JAWS/NVDA (Windows), ChromeVox (ChromeOS), Talkback (Android), and VoiceOver (macOS/iOS). |
Some updates for my previous
There has been some thinking about the MDC-related |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Based on #11083 (comment), it's unlikely.
Not at this time. The new MDC-based version of |
This comment has been minimized.
This comment has been minimized.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes #11083.
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`. Fixes angular#11083.
This issue tracks rework of the MatSelect component to resolve multiple accessibility issues. Based on this prototype (just the a11y behavior and API, not the visuals)
Summary:
listbox
tocombobox
This should capture issues reported in #5220, #10292, #6382, #3587, #1670
The text was updated successfully, but these errors were encountered: