Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using MAT_SNACK_BAR_DEFAULT_OPTIONS in parent module don't show snackbar at all #11197

Closed
kgrvr opened this issue May 7, 2018 · 2 comments · Fixed by #11230
Closed

Using MAT_SNACK_BAR_DEFAULT_OPTIONS in parent module don't show snackbar at all #11197

kgrvr opened this issue May 7, 2018 · 2 comments · Fixed by #11230
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@kgrvr
Copy link

kgrvr commented May 7, 2018

Bug, feature request, or proposal:

BUG

What is the expected behavior?

Snackbar should be displayed.

What is the current behavior?

Snackbar is not displaying.

What are the steps to reproduce?

Please have a look at StackBlitz: https://stackblitz.com/edit/angular-zihwqu?file=app%2Fsnack-bar-overview-example.ts

  1. Don't provide any Snackbar options when invoking open method.
  2. Provide Snackbar options in parent module.
  3. Try opening Snackbar.

What is the use-case or motivation for changing an existing behavior?

Bug fix

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular CLI: 6.0.0
Node: 8.9.0
OS: win32 x64
Angular: 6.0.0

Is there anything else we should know?

I don't think so
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 7, 2018
@crisbeto crisbeto added the has pr label May 8, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue May 8, 2018
@crisbeto
fix(snack-bar): snack bar not animating in if no positions are passed in
66ba197 
Adds some better handling for the case where no positions are passed into a snack bar. Currently the snack bar attempts to animate in to an invalid animation state.

Fixes angular#11197.
@crisbeto crisbeto mentioned this issue May 8, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue May 9, 2018
@crisbeto
fix(snack-bar): snack bar not animating in if no positions are passed in
42b1d7c 
Adds some better handling for the case where no positions are passed into a snack bar. Currently the snack bar attempts to animate in to an invalid animation state.

Fixes angular#11197.
@Boboss74
Copy link

Boboss74 commented May 9, 2018

In the official https://material.angular.io/components/snack-bar/examples it display nothing too
(v6.0.1)

tinayuangao pushed a commit that referenced this issue May 15, 2018
@crisbeto @tinayuangao
fix(snack-bar): snack bar not animating in if no positions are passed…
f5377dd 
… in (#11230)

Adds some better handling for the case where no positions are passed into a snack bar. Currently the snack bar attempts to animate in to an invalid animation state.

Fixes #11197.
tinayuangao pushed a commit that referenced this issue May 15, 2018
@crisbeto @tinayuangao
fix(snack-bar): snack bar not animating in if no positions are passed…
81a2d59 
… in (#11230)

Adds some better handling for the case where no positions are passed into a snack bar. Currently the snack bar attempts to animate in to an invalid animation state.

Fixes #11197.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 15, 2018
@crisbeto
fix(snack-bar): snack bar not animating in if no positions are passed…
04734b6 
… in (angular#11230)

Adds some better handling for the case where no positions are passed into a snack bar. Currently the snack bar attempts to animate in to an invalid animation state.

Fixes angular#11197.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 15, 2018
@crisbeto
fix(snack-bar): snack bar not animating in if no positions are passed…
855be9f 
… in (angular#11230)

Adds some better handling for the case where no positions are passed into a snack bar. Currently the snack bar attempts to animate in to an invalid animation state.

Fixes angular#11197.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(snack-bar): snack bar not animating in if no positions are passed in crisbeto/material2
4 participants
@Boboss74 @jelbourn @crisbeto @kgrvr