-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration errors multiple TypeError #11571
Comments
Additionally the |
You have to update |
Assuming you are proposing cdk update first before material update, which I will try. But And if you run update on material it should promptly fail or suggest a cdk ypdate warning. OTOH after the errors I noticed the refactoring it did but can't say if it was complete since the errors. Also that update brought in cdk as expected so not sure why cdk update must be done explicitly before material update. |
Still same errors with first cdk and then material update like below: ng update @angular/cdk --migrate-only --from 5.0.3 --to 6.2.0
ng update @angular/material --migrate-only --from 5.0.3 --to 6.2.0 |
Additional findings: On another project where I upgraded core and CLI that already has
I get following error:-
when I perform
|
@andrewseguin Try the steps Sample starter repo created using ng new using @angular/cli@6.0.3
My guess is the problem is due to version mismatch of |
I'm getting a different TypeError, when updating @angular/material from 5.2.5
are there any known workarounds? |
After some debugging I noticed there are coming from the material schematic templates themselves. schematics/update/files. However my mixinTabs are giving tslint errors. |
This is fixed on latest.
Yes, the CDK and Material must always be aligned.
Can you give anymore specifics?
You should exclude
@deantoni what typescript version are you on? |
|
|
What typescript version are you on? That looks like a typescript parser issue. |
Described in the ticket. 2.7.2 |
Currently if someone uses a namespace import or an import without named bindings in an Angular application, the `ng-update` schematics from Angular Material will fail due to missing safety checks before casting. Fixes angular#11571
…ed (angular#12866) Currently if someone uses a namespace import or an import without named bindings in an Angular application, the `ng-update` schematics from Angular Material will fail due to missing safety checks before casting. Fixes angular#11571
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
No errors
What is the current behavior?
After running
I run into many errors.
What are the steps to reproduce?
Sample starter repo created using
ng new
using @angular/cli@6.0.3You can clone this
https://github.com/yogeshgadge/my-ng6
branch
with-material-errors
https://github.com/yogeshgadge/my-ng6.git
npm install
ng update @angular/material --migrate-only --from 5.0.3 --to 6.2.0
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
To disable this warning use "ng config -g cli.warnings.versionMismatch false".
/ △ \ | '_ \ /
| | | | |/ _
| '__| | | | | | |/ ___ | | | | (| | || | | (| | | | || | | |
// __| ||_, |_,||_,|| _|||
|___/
Angular CLI: 6.0.3
Node: 10.0.0
OS: win32 x64
Angular: 6.0.3
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package Version
@angular-devkit/architect 0.6.3
@angular-devkit/build-angular 0.6.3
@angular-devkit/build-optimizer 0.6.3
@angular-devkit/core 0.6.3
@angular-devkit/schematics 0.6.3
@angular/cdk 6.0.0
@angular/flex-layout 6.0.0-beta.15
@angular/material 6.0.0
@ngtools/webpack 6.0.3
@schematics/angular 0.6.3
@schematics/update 0.6.3
rxjs 6.2.0
typescript 2.7.2
webpack 4.8.3
Is there anything else we should know?
ng add @angular/material
works fine just the migrate scripts have issues.The text was updated successfully, but these errors were encountered: