Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: mat-select components can create aria-labelledby attributes with invalid values #12405

Closed
chrisboaks opened this issue Jul 27, 2018 · 1 comment · Fixed by #12411
Closed

a11y: mat-select components can create aria-labelledby attributes with invalid values #12405

chrisboaks opened this issue Jul 27, 2018 · 1 comment · Fixed by #12411
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful

Comments

@chrisboaks
Copy link

Bug, feature request, or proposal:

a11y bug: mat-select components can create aria-labelledby attributes with invalid values.

What is the expected behavior?

mat-select aria-labelledby values are always valid.

What is the current behavior?

mat-select aria-labelledby values are not always valid.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-vkhysf-pmuokg?file=app/select-value-binding-example.html

  1. Inspect the mat-select tag on the above page
  2. Note the value in the aria-labelledby attribute ("mat-form-field-label-1")
  3. Note that there are no elements on the page with that id.

What is the use-case or motivation for changing an existing behavior?

Achieving GAR4 in my app.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular + Material: HEAD
OS/TS/Browsers: all

Is there anything else we should know?

I believe the issue was introduced in this commit: e349fe4
@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue labels Jul 27, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 27, 2018
@crisbeto
fix(select): pointing to non-existent element via aria-labelledby
eaaf0f0 
Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes angular#12405.
@crisbeto crisbeto mentioned this issue Jul 27, 2018
Merged
jelbourn pushed a commit that referenced this issue Aug 23, 2018
@crisbeto @jelbourn
fix(select): pointing to non-existent element via aria-labelledby
3936345 
Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes #12405.
jelbourn pushed a commit that referenced this issue Aug 25, 2018
@crisbeto @jelbourn
fix(select): pointing to non-existent element via aria-labelledby
e56a832 
Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes #12405.
jelbourn pushed a commit that referenced this issue Aug 27, 2018
@crisbeto @jelbourn
fix(select): pointing to non-existent element via aria-labelledby (#1…
3b7f0f1 
…2411)

Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes #12405.
jelbourn pushed a commit that referenced this issue Aug 29, 2018
@crisbeto @jelbourn
fix(select): pointing to non-existent element via aria-labelledby (#1…
12c6f81 
…2411)

Fixes `mat-select` referring to an element that doesn't exist, through `aria-labelledby`, if the select is inside a form field that doesn't have a label.

Fixes #12405.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) G This is is related to a Google internal issue P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): pointing to non-existent element via aria-labelledby crisbeto/material2
3 participants
@jelbourn @crisbeto @chrisboaks