Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabindex on MatDatepickerToggle #12456

Closed
mattmcardle opened this issue Jul 31, 2018 · 1 comment · Fixed by #12461
Closed

tabindex on MatDatepickerToggle #12456

mattmcardle opened this issue Jul 31, 2018 · 1 comment · Fixed by #12461
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mattmcardle
Copy link

Bug, feature request, or proposal:

Feature Request

What is the expected behavior?

When specifying a tabindex of -1 on the datepicker toggle, and focus is on the datepickers associated input element,when tab is pressed the focus should skip the datepicker toggle and focus on the next focusable element. (As per https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)

What is the current behavior?

When specifying a tabindex of -1 on the datepicker toggle, and focus is on the datepickers associated input element, when tab is pressed the focus goes to the datepicker toggle, ignoring the tabindex of -1.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-xzdzcf

What is the use-case or motivation for changing an existing behavior?

Reducing keypresses required from user to move through the form

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Latest stable - tested in chrome.

Is there anything else we should know?

@crisbeto crisbeto self-assigned this Jul 31, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 31, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes angular#12456.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jul 31, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 31, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes angular#12456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 5, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes angular#12456.
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 12, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes angular#12456.
jelbourn pushed a commit that referenced this issue Aug 24, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes #12456.
jelbourn pushed a commit that referenced this issue Aug 24, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes #12456.
jelbourn pushed a commit that referenced this issue Aug 29, 2018
Forwards the tabindex of a `mat-button-toggle` to its underlying `button` and clears it from the host element.

Fixes #12456.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants