Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment issue with Stepper's numbers #12696

Closed
amiralgazi opened this issue Aug 16, 2018 · 4 comments · Fixed by #12703
Closed

Alignment issue with Stepper's numbers #12696

amiralgazi opened this issue Aug 16, 2018 · 4 comments · Fixed by #12703
Assignees
@crisbeto
Labels
P4 A relatively minor issue that is not relevant to core functions

Comments

@amiralgazi
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The stepper's numbers are aligned to the center

What is the current behavior?

The stepper's numbers are not aligned to the center in some resolutions

untitled

What is the use-case or motivation for changing an existing behavior?

Design consistency
@devversion
Copy link
Member

devversion commented Aug 16, 2018 •
edited
Loading

Can you explain what resolution you're using for example? I will try to look into it in the meanwhile.

@devversion devversion added the needs: clarification The issue does not contain enough information for the team to determine if it is a real bug label Aug 16, 2018
@devversion
Copy link
Member

Also some information about your browser, operating system etc. would be appreciated. Thanks

crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 16, 2018
@crisbeto
fix(stepper): improved alignment for step icons
36d8502 
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes angular#12696.
@crisbeto crisbeto mentioned this issue Aug 16, 2018
Merged
@crisbeto crisbeto added has pr P4 A relatively minor issue that is not relevant to core functions and removed needs: clarification The issue does not contain enough information for the team to determine if it is a real bug labels Aug 16, 2018
@crisbeto crisbeto self-assigned this Aug 16, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 16, 2018
@crisbeto
fix(stepper): improved alignment for step icons
ca6b26a 
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes angular#12696.
@amiralgazi
Copy link
Author

@devversion
Screen resolution is: 1920 x 1080,
Browser is: Version 68.0.3440.106 (Official Build) (64-bit),
Operating system is: 64-Bit Windows 10

jelbourn pushed a commit that referenced this issue Aug 24, 2018
@crisbeto @jelbourn
fix(stepper): improved alignment for step icons
1892662 
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes #12696.
jelbourn pushed a commit that referenced this issue Aug 24, 2018
@crisbeto @jelbourn
fix(stepper): improved alignment for step icons (#12703)
37a7056 
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes #12696.
jelbourn pushed a commit that referenced this issue Aug 29, 2018
@crisbeto @jelbourn
fix(stepper): improved alignment for step icons (#12703)
41d0196 
Switches to using absolute positioning to center the stepper icons. This works better with the text-based icons.

Fixes #12696.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stepper): improved alignment for step icons crisbeto/material2
3 participants
@crisbeto @devversion @amiralgazi