-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Overlay in combination with ag-Grid in Firefox causes too much recursion exception #12972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is also too much recursion regarding placing material datepicker and material select in a modal. After placing a select or datepicker (anything with a further overlay) within a modal, the following are thrown [Show/hide message details.] too much recursion[Learn More] zone.js:163 This then makes the entire tab crash (due to the recursion). This seems to work fine in Chrome (no error is thrown at least). Not even sure I can come up with a workaround if I want to use material datepicker and select within a modal... Edit: Edit2: |
Should be resolved by c2e502c. |
This is not yet resolved. I am on version 7.3.7 of the CDK and still see this with material modals containing ag-grid. Note that upgrading to ag-grid-community 20 fixes the issue. |
Ah, it was also an ag-grid issue for me. I forgot we were using ag-grid on that page, upgrading it worked for me |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug
What is the current behavior?
Angular Material 6.4.3 and up causes an "too much recursion" exception on components where ag-Grid is used and a modal or drawer opens.
Happens only in Firefox (61.0.2) where Chrome (68.0.3440.106) works just fine.
Downgrading to angular material 6.4.2 resolves this issue. (That's why I'll post the error here first and not on ag-Grid)
What are the steps to reproduce?
TODO - Need to setup free ag-Grid with material drawer or modal in stackblitz
UPDATE: Tried to replicate the issue in striped down project with just an overley drawer and bare minimum ag-grid and of course thats working... so this will be rather fun to reproduce.
Stacktrace
NotFoundError exception is thrown 115 times...
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/animations": "6.1.6",
"@angular/cdk": "6.4.7",
"@angular/common": "6.1.6",
"@angular/compiler": "6.1.6",
"@angular/core": "6.1.6",
"@angular/forms": "6.1.6",
"@angular/http": "6.1.6",
"@angular/material": "6.4.7",
"@angular/platform-browser": "6.1.6",
"@angular/platform-browser-dynamic": "6.1.6",
"@angular/router": "6.1.6",
"@ctrl/ngx-codemirror": "1.3.8",
"ag-grid": "18.1.2",
"ag-grid-angular": "18.1.0",
"ag-grid-enterprise": "18.1.1",
"angular2-uuid": "1.1.1",
"bootstrap": "4.1.3",
"codemirror": "5.40.0",
"core-js": "2.5.7",
"hammerjs": "2.0.8",
"moment": "2.22.2",
"ng2-dnd": "5.0.2",
"popper.js": "1.14.4",
"rxjs": "6.3.1",
"zone.js": "0.8.26"
Browser: Firefox (61.0.2)
"typescript": "2.9.2"
AOT
ES6
The text was updated successfully, but these errors were encountered: