Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatSlider: text selection cursor shows while sliding #14613

Closed
nigel5 opened this issue Dec 23, 2018 · 1 comment · Fixed by #16680
Closed

MatSlider: text selection cursor shows while sliding #14613

nigel5 opened this issue Dec 23, 2018 · 1 comment · Fixed by #16680
Assignees
@crisbeto @mmalerba
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@nigel5
Copy link
Contributor

nigel5 commented Dec 23, 2018 •
edited
Loading

What is the expected behavior?

When sliding the mat-slider, the cursor state should be "dragging"
expected

What is the current behavior?

The cursor state is "text"

issue

What are the steps to reproduce?

Visit the slider example and drag the slider left/right.

Observe text cursor instead of dragging cursor.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Material 7.20 (the version on the example website)
macOS 10.14.2 Mojave
Safari 12.0.2

Is there anything else we should know?

No
@nigel5 nigel5 changed the title MatSlider: cursor should be "dragging" MatSlider: text selection cursor shows while sliding Dec 23, 2018
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Aug 4, 2019
@crisbeto crisbeto self-assigned this Aug 4, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 4, 2019
@crisbeto
fix(slider): inconsistent cursor behavior if user's pointer moves aro…
324128c 
…und while dragging

Currently we only change the cursor in the slider if the user's pointer is over the thumb or thumb label. This doesn't work very well while dragging, because the elements aren't very large and the pointer could move off of it temporarily while dragging. These changes make it so the cursor for the entire slider is changed while dragging.

Furthermore, on Safari the cursor goes into text selection mode while dragging. These changes address this issue as well.

Fixes angular#14613.
@crisbeto crisbeto mentioned this issue Aug 4, 2019
Merged
andrewseguin pushed a commit that referenced this issue Aug 21, 2019
@crisbeto @andrewseguin
fix(slider): inconsistent cursor behavior if user's pointer moves aro…
7039b25 
…und while dragging

Currently we only change the cursor in the slider if the user's pointer is over the thumb or thumb label. This doesn't work very well while dragging, because the elements aren't very large and the pointer could move off of it temporarily while dragging. These changes make it so the cursor for the entire slider is changed while dragging.

Furthermore, on Safari the cursor goes into text selection mode while dragging. These changes address this issue as well.

Fixes #14613.
andrewseguin pushed a commit that referenced this issue Aug 26, 2019
@crisbeto @andrewseguin
fix(slider): inconsistent cursor behavior if user's pointer moves aro…
d62b19e 
…und while dragging

Currently we only change the cursor in the slider if the user's pointer is over the thumb or thumb label. This doesn't work very well while dragging, because the elements aren't very large and the pointer could move off of it temporarily while dragging. These changes make it so the cursor for the entire slider is changed while dragging.

Furthermore, on Safari the cursor goes into text selection mode while dragging. These changes address this issue as well.

Fixes #14613.

(cherry picked from commit 7039b25)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

@mmalerba mmalerba

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
3 participants
@crisbeto @mmalerba @nigel5