Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTML5 canvas elements when cloning drag preview #15685

Closed
masaala opened this issue Apr 2, 2019 · 1 comment · Fixed by #15808
Closed

Support HTML5 canvas elements when cloning drag preview #15685

masaala opened this issue Apr 2, 2019 · 1 comment · Fixed by #15808
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@masaala
Copy link

masaala commented Apr 2, 2019

Please describe the feature you would like to request.

Would be nice if default cdkDragPreview element would copy canvas elements too. Now one needs to handle copying process by their own and create custom cdkDragPreview elements to be shown in preview.

What is the use-case or motivation for this proposal?

For example drag drop list of charts.

Is there anything else we should know?

Here you can find simplified example to see canvas element disappearing from drag preview.
https://stackblitz.com/edit/angular-efx3ry
@crisbeto crisbeto self-assigned this Apr 5, 2019
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Apr 13, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 13, 2019
@crisbeto
fix(drag-drop): preview element not maintaining canvas data
13d9918 
By default we generate the preview and placeholder for a `cdkDrag` using `cloneNode`, however it won't clone the content of `canvas` elements. These changes add some extra logic to transfer the canvas content over into the clones.

Fixes angular#15685.
@crisbeto crisbeto mentioned this issue Apr 13, 2019
Merged
@andrewseguin andrewseguin added the feature This issue represents a new feature or feature request rather than a bug or bug fix label May 6, 2019
jelbourn pushed a commit that referenced this issue May 13, 2019
@crisbeto @jelbourn
fix(drag-drop): preview element not maintaining canvas data (#15808)
31e72a7 
By default we generate the preview and placeholder for a `cdkDrag` using `cloneNode`, however it won't clone the content of `canvas` elements. These changes add some extra logic to transfer the canvas content over into the clones.

Fixes #15685.
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this issue Jun 21, 2019
@crisbeto @RudolfFrederiksen
fix(drag-drop): preview element not maintaining canvas data (angular#…
5c2970a 
…15808)

By default we generate the preview and placeholder for a `cdkDrag` using `cloneNode`, however it won't clone the content of `canvas` elements. These changes add some extra logic to transfer the canvas content over into the clones.

Fixes angular#15685.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(drag-drop): preview element not maintaining canvas data crisbeto/material2
3 participants
@masaala @crisbeto @andrewseguin