-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Itemize sanity checks #16617
Comments
mina-skunk
added
the
feature
This issue represents a new feature or feature request rather than a bug or bug fix
label
Jul 26, 2019
andrewseguin
added
the
P4
A relatively minor issue that is not relevant to core functions
label
Jul 31, 2019
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 4, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes angular#16617.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 4, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes angular#16617.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 4, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes angular#16617.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 5, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes angular#16617.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 5, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes angular#16617.
jelbourn
pushed a commit
that referenced
this issue
Sep 6, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes #16617.
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Sep 7, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes angular#16617.
jelbourn
pushed a commit
that referenced
this issue
Sep 16, 2019
Allows consumers to disable individual sanity checks, rather than the all-or-nothing setup that we have at the moment. Fixes #16617.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Description
Change type that
MATERIAL_SANITY_CHECKS
provides fromboolean
to:or even type
boolean | SanityChecks
for backwards compatUse Case
We dynamically add the theme
scss
based on the user, this causes the warningcomponents/src/material/core/common-behaviors/common-module.ts
Lines 105 to 109 in 7f74211
because the theme is not loaded yet when this code runs. Currently, to disable the warning we:
although the other checks could still be useful, if you could do
The text was updated successfully, but these errors were encountered: