Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu ripple doesn't work if scrolled beneath the fold #1811

Closed
kara opened this issue Nov 10, 2016 · 8 comments
Closed

Menu ripple doesn't work if scrolled beneath the fold #1811

kara opened this issue Nov 10, 2016 · 8 comments
Assignees

Comments

@kara
Copy link
Contributor

kara commented Nov 10, 2016

Looking into it!

Edit: It turns out that the ripple is acting funky if scrolled beneath the fold. For some reason, it takes longer to animate and so it isn't removed before the menu closes.

Related to #1817 & #1818

@kara kara self-assigned this Nov 10, 2016
@csabattilas
Copy link

@kara hi. I understand (i guess) what you mean now. Are you working on this? If not i can pick it up. thanks

@kara
Copy link
Contributor Author

kara commented Nov 10, 2016

Yep, working on it. Generally when I assign something to myself, I'm working on it.

@csabattilas
Copy link

Ah ok then I should leave it. Sorry.

@csabattilas
Copy link

Is that a general rule here that if someone is assigned to an issue they are working on it? Or they are assigned but it might happen that it's not in progress? Just trying to pick up an issue and not overlapping with others. thanks

@kara
Copy link
Contributor Author

kara commented Nov 10, 2016

@krigton Fair point. If you see that an issue hasn't gotten any activity in a while (like a few weeks), the best thing is just to ask like you did here if the assignee is ok with you taking it on.

Also check out the "projects" section. I keep track of my current workload in there, so typically if it's on the board, I plan on working on it soon.

@kara kara changed the title Menu close animation doesn't happen in AOT Menu ripple doesn't work if scrolled beneath the fold Nov 11, 2016
@csabattilas
Copy link

thanks!

@kara
Copy link
Contributor Author

kara commented Feb 10, 2017

Should have been fixed by #1915

@kara kara closed this as completed Feb 10, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants