Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDC Web version of chips doesn't respect NoopAnimationsModule #18642

Closed
heathkit opened this issue Feb 27, 2020 · 1 comment · Fixed by #18653, lingounet/testage#29 or michael-vasyliv/ngx-virtual-swiper#24
Closed

MDC Web version of chips doesn't respect NoopAnimationsModule #18642

heathkit opened this issue Feb 27, 2020 · 1 comment · Fixed by #18653, lingounet/testage#29 or michael-vasyliv/ngx-virtual-swiper#24
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@heathkit
Copy link

Reproduction

Steps to reproduce:

  1. Set up an autocomplete dialog with chips
  2. Import 'NoopAnimationsModule'

Even though _animationsDisabled is true on the mat-chip component, it still renders the entry animation from here

See b/150330611 for an example test

Expected Behavior

The animation should be disabled.

Actual Behavior

The animation is applied! The chips still pop in, you can see the animation in the CSS, etc.

Environment

  • Angular: Head
  • CDK/Material: HEAD (MDC Web)
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Linux
@crisbeto crisbeto self-assigned this Feb 28, 2020
@crisbeto crisbeto added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Feb 28, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 28, 2020
@crisbeto
fix(material-experimental/mdc-chips): enter animation not disabled wh…
8b61e92 
…en using noop animations

Fixes the MDC chips not disabling the chip enter animation when using the `NoopAnimationsModule`.

Fixes angular#18642.
@crisbeto crisbeto mentioned this issue Feb 28, 2020
Merged
mmalerba pushed a commit that referenced this issue Apr 7, 2020
@crisbeto @mmalerba
fix(material-experimental/mdc-chips): enter animation not disabled wh…
7e3c5a5 
…en using noop animations

Fixes the MDC chips not disabling the chip enter animation when using the `NoopAnimationsModule`.

Fixes #18642.
mmalerba pushed a commit that referenced this issue Apr 7, 2020
@crisbeto
fix(material-experimental/mdc-chips): enter animation not disabled wh…
b225b87 
…en using noop animations (#18653)

Fixes the MDC chips not disabling the chip enter animation when using the `NoopAnimationsModule`.

Fixes #18642.
mmalerba pushed a commit that referenced this issue Apr 14, 2020
@crisbeto @mmalerba
fix(material-experimental/mdc-chips): enter animation not disabled wh…
ea32d14 
…en using noop animations (#18653)

Fixes the MDC chips not disabling the chip enter animation when using the `NoopAnimationsModule`.

Fixes #18642.
This was referenced May 3, 2020
Merged
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@heathkit @crisbeto