Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(@angular/google-maps): Map Info Window isn't opened when call open() without params #21013

Closed
Ajax-ua opened this issue Nov 11, 2020 · 1 comment · Fixed by #21014
Closed

bug(@angular/google-maps): Map Info Window isn't opened when call open() without params #21013

Ajax-ua opened this issue Nov 11, 2020 · 1 comment · Fixed by #21014
Assignees
@crisbeto
Labels
area: google-maps P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Ajax-ua
Copy link

Ajax-ua commented Nov 11, 2020

Reproduction

Use StackBlitz to reproduce your issue: https://components-issue-1jnycv.stackblitz.io

Steps to reproduce:

  1. Right click on the map. The info window should appear
  2. In package.json, change @angular/google-maps version to 9.2.4. Then right click on the map. The info window appears

Expected Behavior

The info window should appear on @angular/google-maps v10.

Actual Behavior

The info window doesn't appear
@Ajax-ua Ajax-ua added the needs triage This issue needs to be triaged by the team label Nov 11, 2020
@crisbeto crisbeto self-assigned this Nov 11, 2020
@crisbeto crisbeto added area: google-maps has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels Nov 11, 2020
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 11, 2020
@crisbeto
fix(google-maps): info window not opening if no anchor is passed in
0b49d85 
Some time ago we added logic to prevent the info window from reopening if the same
anchor is passed in. This ended up breaking the use case where a window is opened
without an anchor, because the window always starts off without one.

Fixes angular#21013.
@crisbeto crisbeto mentioned this issue Nov 11, 2020
Merged
wagnermaciel pushed a commit that referenced this issue Nov 17, 2020
@crisbeto
fix(google-maps): info window not opening if no anchor is passed in (#…
17c357f 
…21014)

Some time ago we added logic to prevent the info window from reopening if the same
anchor is passed in. This ended up breaking the use case where a window is opened
without an anchor, because the window always starts off without one.

Fixes #21013.
wagnermaciel pushed a commit that referenced this issue Nov 17, 2020
@crisbeto @wagnermaciel
fix(google-maps): info window not opening if no anchor is passed in (#…
36cb325 
…21014)

Some time ago we added logic to prevent the info window from reopening if the same
anchor is passed in. This ended up breaking the use case where a window is opened
without an anchor, because the window always starts off without one.

Fixes #21013.

(cherry picked from commit 17c357f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2020
wagnermaciel pushed a commit to wagnermaciel/components that referenced this issue Jan 14, 2021
@crisbeto @wagnermaciel
fix(google-maps): info window not opening if no anchor is passed in (a…
60b5bef 
…ngular#21014)

Some time ago we added logic to prevent the info window from reopening if the same
anchor is passed in. This ended up breaking the use case where a window is opened
without an anchor, because the window always starts off without one.

Fixes angular#21013.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: google-maps P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(google-maps): info window not opening if no anchor is passed in crisbeto/material2
2 participants
@crisbeto @Ajax-ua