dev-app has 404 for localize-init bundle when deployed to firebase #22943
Assignees
Labels
area: dev-infra
Issue related to internal project infrastructure
in progress
This issue is currently in progress
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
jelbourn
added
P3
devversion
added a commit
to devversion/material2
that referenced
this issue
Jun 11, 2021
The `@angular/localize` package does not contain any `.metadata.json` files, or an `ANGULAR_PACKAGE` marker file. This results in the NodeJS bazel rules not capturing the UMD files within the `NamedModule` provider. We fix this by using the standard module provider for extracting JS sources from TS targets and its transitive dependencies. This is more long-term proof as the hard-coded Angular package logic within Rules NodeJS is most likely not a long-term solution. see: https://github.com/bazelbuild/rules_nodejs/blob/stable/internal/npm_install/generate_build_file.ts#L1080-L1081 Fixes angular#22943.
wagnermaciel
pushed a commit
that referenced
this issue
Jun 15, 2021
The `@angular/localize` package does not contain any `.metadata.json` files, or an `ANGULAR_PACKAGE` marker file. This results in the NodeJS bazel rules not capturing the UMD files within the `NamedModule` provider. We fix this by using the standard module provider for extracting JS sources from TS targets and its transitive dependencies. This is more long-term proof as the hard-coded Angular package logic within Rules NodeJS is most likely not a long-term solution. see: https://github.com/bazelbuild/rules_nodejs/blob/stable/internal/npm_install/generate_build_file.ts#L1080-L1081 Fixes #22943.
wagnermaciel
pushed a commit
that referenced
this issue
Jun 15, 2021
The `@angular/localize` package does not contain any `.metadata.json` files, or an `ANGULAR_PACKAGE` marker file. This results in the NodeJS bazel rules not capturing the UMD files within the `NamedModule` provider. We fix this by using the standard module provider for extracting JS sources from TS targets and its transitive dependencies. This is more long-term proof as the hard-coded Angular package logic within Rules NodeJS is most likely not a long-term solution. see: https://github.com/bazelbuild/rules_nodejs/blob/stable/internal/npm_install/generate_build_file.ts#L1080-L1081 Fixes #22943. (cherry picked from commit 9428939)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When I attempt to deploy the dev-app to firebase, the application fails to load because the umd bundle
localize-init.umd.js404s:I poked around
tools/system-config-tmpl.jsand couldn't find anything that seemed wrong for the localize package.My most recent successful deployment was May 19th. @devversion any thoughts as to what's going on?
The text was updated successfully, but these errors were encountered: