Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mat-tab-nav-bar): router-outlet transition animation like mat-tab-group #24053

Open
infacto opened this issue Dec 3, 2021 · 3 comments
Open
Labels
area: material/tabs feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@infacto
Copy link

infacto commented Dec 3, 2021

Feature Description

When enableing tab navigation, I have to use mat-tab-nav-bar instead of mat-tab-group. Works great, but removes the transition animation between the tabs (sliding left / right).

There are some other related issues about it: #15570, #18169

I cannot accept the answer that I should use mat-tab-group instead. The reason using mat-tab-nav-bar is the tab navigation over URL, etc. Or do you generally not recommend this? If yes why?

The workaround in the other solution works. But I wonder, why not just implement this this framework? Since the mat-tab-group already has this animation. What is the reason for refusing such a legitimate request?

I don't like to write code / workaround for stuff that should actually be part of the framework. Custom data with index for the animation, etc.

No offense, I was just wondering what the problem is. Together we could think about an elegant solution. Maybe a directive for the router-outlet container? But how to detect left and right sliding? (See workaround #18169)

Use Case

Just be consistent to mat-tab-group. Why not? Why should we regret implementing tab navigation using mat-tab-nav-bar. Which is an awesome feature? Just complete the implementation by adding the same animation like in mat-tab-group.

@infacto infacto added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Dec 3, 2021
@crisbeto
Copy link
Member

crisbeto commented Dec 7, 2021

We can't implement this, because we don't know what element your content will be rendered into. There's a recent PR (#24062) to add a component that wraps the router outlet which could allow us to implement the animation.

@andrewseguin andrewseguin reopened this Dec 9, 2021
@andrewseguin andrewseguin added area: material/tabs and removed needs triage This issue needs to be triaged by the team labels Dec 9, 2021
@angular-robot
Copy link
Contributor

angular-robot bot commented Mar 14, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@angular-robot
Copy link
Contributor

angular-robot bot commented Apr 3, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: material/tabs feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

3 participants