-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(style): Custom palette's text
hue not propagated to MDC styles
#26021
Comments
theme
hue not propagated to MDC stylestext
hue not propagated to MDC styles
I have 2 themes (light and dark) which both have black as the primary theme color. In v14 the text of buttons inside the toolbar had white color no matter if the theme was dark or light. Now with v15 text is white in dark but black in light. So, my text is invisible in dark. Looks that 14 used to care about the contrast in color and adapt text to it. Now it just sets black in light and white in dark which is a bad oversimplification. |
Same issue. |
Duplicate of #26056 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Is this a regression?
The previous version in which this bug was not present was
14.x
Description
[This is a regression insofar as the legacy non-MDC implementations do not have this problem]
Hi, after running the MDC schematic on one of my projects I have found that the MDC-based components do not use the
$text
hue specified in the theme config, which can cause accessibility issues for themes whose default hues do not provide sufficient contrast against a neutral background. In particular I have noticed this causes legibility issues for the floating placeholder on form fields and the label text on default-appearance buttons, but it might apply to other components as well.My theme is configured as follows:
Note that the
$text
hue is overridden to700
in the call todefine-palette
.Here is a screenshot showing the 700 hue being correctly applied to the aforementioned text elements under the legacy components:
And here is how the new MDC components look:
I had a hard time reading the Angular Material => MDC SCSS theming code but it seems like the
$text
hue preference isn't being passed to the MDC mixins in any way.Reproduction
StackBlitz
Expected Behavior
MDC components should use specified text hue where applicable
Actual Behavior
MDC components used primary hue regardless
Environment
The text was updated successfully, but these errors were encountered: