Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(youtube-player): videoId required for initialization #27529

Closed
1 task
drullo opened this issue Jul 27, 2023 · 1 comment · Fixed by #27588
Closed
1 task

bug(youtube-player): videoId required for initialization #27529

drullo opened this issue Jul 27, 2023 · 1 comment · Fixed by #27588
Labels
area: youtube-player P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@drullo
Copy link

drullo commented Jul 27, 2023

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Using playerVars, it is possible to specify a video/list to play upon initialization - eliminating the (redundant) need to specify a videoId property. However, the player won't initialize if videoId is missing.

Reproduction

<youtube-player [playerVars]="playerVars"></youtube-player>

playerVars = {
    list: 'LISTID',
    listtype: 'playlist'
  };

Expected Behavior

If video is specified in playerVars, don't require videoId property to have a value

Actual Behavior

No player displayed when videoId is missing

Environment

  • Angular: 16.1.6
  • Operating System: Windows 10
@drullo drullo added the needs triage This issue needs to be triaged by the team label Jul 27, 2023
@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: youtube-player and removed needs triage This issue needs to be triaged by the team labels Aug 1, 2023
jamesikanos added a commit to jamesikanos/angular-material-components that referenced this issue Aug 5, 2023
@jamesikanos
fix(youtube-player): Allow playlists without specifying videoId (angu…
2515f65 
…lar#27529)

When using a YouTube Player, it is possible to specify a playlist without specifying a videoId. This is useful when you want to play a playlist and don't have a VideoId.

Previously, the player would not initialise if a VideoId wasn't specified but a Playlist was specified, even though the YouTube API supports this use case.

This commit adds support for this use case.
jamesikanos added a commit to jamesikanos/angular-material-components that referenced this issue Aug 5, 2023
@jamesikanos
fix(youtube-player): Allow playlists without specifying videoId (angu…
1cd085f 
…lar#27529)

When using a YouTube Player, it is possible to specify a playlist without specifying a videoId. This is useful when you want to play a playlist and don't have a VideoId.

Previously, the player would not initialise if a VideoId wasn't specified but a Playlist was specified, even though the YouTube API supports this use case.

This commit adds support for this use case.
@jamesikanos jamesikanos mentioned this issue Aug 5, 2023
Merged
crisbeto pushed a commit that referenced this issue Aug 7, 2023
@jamesikanos
fix(youtube-player): Allow playlists without specifying videoId (#27529…
d41be3d 
…) (#27588)

* fix(youtube-player): Allow playlists without specifying videoId (#27529)

When using a YouTube Player, it is possible to specify a playlist without specifying a videoId. This is useful when you want to play a playlist and don't have a VideoId.

Previously, the player would not initialise if a VideoId wasn't specified but a Playlist was specified, even though the YouTube API supports this use case.

This commit adds support for this use case.

* refactor(youtube-player): fixed spelling mistake
crisbeto pushed a commit that referenced this issue Aug 7, 2023
@jamesikanos @crisbeto
fix(youtube-player): Allow playlists without specifying videoId (#27529…
9ec77aa 
…) (#27588)

* fix(youtube-player): Allow playlists without specifying videoId (#27529)

When using a YouTube Player, it is possible to specify a playlist without specifying a videoId. This is useful when you want to play a playlist and don't have a VideoId.

Previously, the player would not initialise if a VideoId wasn't specified but a Playlist was specified, even though the YouTube API supports this use case.

This commit adds support for this use case.

* refactor(youtube-player): fixed spelling mistake

(cherry picked from commit d41be3d)
crisbeto pushed a commit that referenced this issue Aug 7, 2023
@jamesikanos @crisbeto
fix(youtube-player): Allow playlists without specifying videoId (#27529…
013f8a4 
…) (#27588)

* fix(youtube-player): Allow playlists without specifying videoId (#27529)

When using a YouTube Player, it is possible to specify a playlist without specifying a videoId. This is useful when you want to play a playlist and don't have a VideoId.

Previously, the player would not initialise if a VideoId wasn't specified but a Playlist was specified, even though the YouTube API supports this use case.

This commit adds support for this use case.

* refactor(youtube-player): fixed spelling mistake

(cherry picked from commit d41be3d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: youtube-player P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
2 participants
@drullo @andrewseguin