Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog using title, content, actions does not work well on small height screens #2775

Open
andrewseguin opened this issue Jan 24, 2017 · 1 comment
Open

Dialog using title, content, actions does not work well on small height screens #2775

andrewseguin opened this issue Jan 24, 2017 · 1 comment
Labels
area: material/dialog P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@andrewseguin
Copy link
Contributor

Bug, feature request, or proposal:

When using a dialog with the md-dialog-title, md-dialog-content, and md-dialog-actions directives, the dialog does not correctly scale with the screen when the height is reduced.

What is the expected behavior?

The entire dialog should fit into the window while the content height shrinks and is scrollable.

What is the current behavior?

The dialog doesnt quite fit all the way into the window, extends barely past the window

What are the steps to reproduce?

Go into the plunker and shrink the height of the window until the dialog is cut off

https://plnkr.co/edit/LeINuG6ER11R0k8clSYJ?p=preview
@crisbeto
Copy link
Member

#2546 should help with this.

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jan 24, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 25, 2017
@crisbeto
refactor(dialog): better handling of scrollable content
55f1974 
Currently, the dialog's scrollable content (md-dialog-content) is limited to 65% of the viewport height, however on smaller screens the dialog still ends up being too high. This proposal reworks the `md-dialog-content` to make it take up all of the remaining height, instead of being hardcoded to 65%. The max height is provided by the wrapper instead.

Fixes angular#2481.
Fixes angular#2775.
@crisbeto crisbeto mentioned this issue Jan 25, 2017
Closed
@mmalerba mmalerba removed the has pr label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: material/dialog P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dialog): better handling of scrollable content crisbeto/material2
4 participants
@jelbourn @crisbeto @mmalerba @andrewseguin