-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(M3 mat-card): Elevated card uses the wrong surface color #29163
Comments
The tokens are outside of our scope and would need to be fixed in the dependency https://github.com/material-components/material-components-web I suggest filing the issue there |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Re-opening because our repository now owns its own token definitions rather than importing them from another package |
update elevated card container color from `surface` to `surface-container-low` matching the M3 specification fixes angular#29163
Is this a regression?
The previous version in which this bug was not present was
No response
Description
MDC M3 specification (https://m3.material.io/components/cards/specs) dictates that enabled elevated card container color should be md.sys.color.surface-container-low
However, in @material/tokens/v0_161/_md-comp-elevated-card.scss we have
...
'container-color': map.get($deps, 'md-sys-color', 'surface'),
...
Should be changed to
'container-color': map.get($deps, 'md-sys-color', 'surface-container-low'),
Reproduction
No need for reproduction -- this is clearly not according to specification.
Expected Behavior
An elevated card with 'surface-container-low' background
Actual Behavior
An elevated card with 'surface' background
Environment
The text was updated successfully, but these errors were encountered: