Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MatTab): MatTabGroup #29486

Closed
clamli opened this issue Jul 25, 2024 · 1 comment · Fixed by #29562
Closed

feat(MatTab): MatTabGroup #29486

clamli opened this issue Jul 25, 2024 · 1 comment · Fixed by #29562
Assignees
@crisbeto
Labels
Accessibility This issue is related to accessibility (a11y) area: material/tabs feature This issue represents a new feature or feature request rather than a bug or bug fix P2 The issue is important to a large percentage of users, with a workaround

Comments

@clamli
Copy link
Contributor

clamli commented Jul 25, 2024

Feature Description

According to the Tabs Pattern, if the tab list has a visible label, the element with role tablist has aria-labelledby set to a value that refers to the labelling element. Otherwise, the tablist element has a label provided by aria-label.

MaTabGroup does not allow users to provide an accessible label via aria-label or aria-labelledby for the element with role tablist.

Use Case

Users of this component can provide a label through either aria-label or aria-labelledby.
@clamli clamli added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Jul 25, 2024
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) area: material/tabs and removed needs triage This issue needs to be triaged by the team labels Aug 6, 2024
@crisbeto crisbeto self-assigned this Aug 9, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue Aug 9, 2024
@crisbeto
fix(material/tabs): allow for tablist aria-label and aria-labelledby …
349cf15 
…to be set

According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set.

Fixes angular#29486.
@crisbeto crisbeto mentioned this issue Aug 9, 2024
Merged
crisbeto added a commit that referenced this issue Aug 14, 2024
@crisbeto
fix(material/tabs): allow for tablist aria-label and aria-labelledby …
1968cc4 
…to be set (#29562)

According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set.

Fixes #29486.
crisbeto added a commit that referenced this issue Aug 14, 2024
@crisbeto
fix(material/tabs): allow for tablist aria-label and aria-labelledby …
f7a0305 
…to be set (#29562)

According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set.

Fixes #29486.

(cherry picked from commit 1968cc4)
crisbeto added a commit that referenced this issue Aug 14, 2024
@crisbeto
fix(material/tabs): allow for tablist aria-label and aria-labelledby …
838d1a4 
…to be set (#29562)

According to the [W3C reference implementation](https://www.w3.org/WAI/ARIA/apg/patterns/tabs/), the inner `tablist` can be labelled using `aria-label` or `aria-labelledby`. These changes add an input to allow them to be set.

Fixes #29486.

(cherry picked from commit 1968cc4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
Accessibility This issue is related to accessibility (a11y) area: material/tabs feature This issue represents a new feature or feature request rather than a bug or bug fix P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/tabs): allow for tablist aria-label and aria-labelledby to be set crisbeto/material2
3 participants
@crisbeto @mmalerba @clamli