Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Datepicker): Datepicker style is affected by body line-height #29756

Open
1 task
keatkeat87 opened this issue Sep 18, 2024 · 0 comments · May be fixed by #29770
Open
1 task

bug(Datepicker): Datepicker style is affected by body line-height #29756

keatkeat87 opened this issue Sep 18, 2024 · 0 comments · May be fixed by #29770
Assignees
@crisbeto
Labels
area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@keatkeat87
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

image

image

Reproduction

StackBlitz link:
Steps to reproduce:

  1. git clone https://github.com/keatkeat87/ng-mat-datepicker-line-height.git
  2. ng serve

Expected Behavior

dates should be inside Datepicker.

Actual Behavior

The dates are pushed out over the Datepicker.

Environment

Angular CLI: 18.2.4
Node: 20.11.1
Package Manager: yarn 1.22.19
OS: win32 x64

Angular: 18.2.4
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, platform-browser, platform-browser-dynamic
... router

Package Version

@angular-devkit/architect 0.1802.4
@angular-devkit/build-angular 18.2.4
@angular-devkit/core 18.2.4
@angular-devkit/schematics 18.2.4
@schematics/angular 18.2.4
rxjs 7.8.1
typescript 5.5.4
zone.js 0.14.10
@keatkeat87 keatkeat87 added the needs triage This issue needs to be triaged by the team label Sep 18, 2024
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 20, 2024
@crisbeto
fix(material/datepicker): set explicit line height on calendar
27a9302 
Sets a `line-height` on the calendar, otherwise it inherits the one from the `body` which can throw off the layout.

Fixes angular#29756.
@crisbeto crisbeto self-assigned this Sep 20, 2024
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: material/datepicker and removed needs triage This issue needs to be triaged by the team labels Sep 20, 2024
@crisbeto crisbeto linked a pull request Sep 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crisbeto crisbeto

Labels
area: material/datepicker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(material/datepicker): set explicit line height on calendar crisbeto/material2
2 participants
@crisbeto @keatkeat87