bug(Timepicker): Problem with MAT_TIMEPICKER_SCROLL_STRATEGY

[laliconfigcat]

Is this a regression?

• Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

First of all, thanks for implementing the MAT_TIMEPICKER_SCROLL_STRATEGY so fast!
I tried it with the newest version released yesterday and I run into a problem with it.

I am using a close scroll strategy like this:

const closeScrollStrategyFactory = (overlay: Overlay): (() => CloseScrollStrategy) => {
  return () => overlay.scrollStrategies.close();
};

...

{ provide: MAT_TIMEPICKER_SCROLL_STRATEGY, useFactory: closeScrollStrategyFactory, deps: [Overlay] },

When I open the Timepicker, it works fine but when the scrolling closes the Timepicker, it cannot be opened again.

Is my scroll strategy wrong somehow? Thanks in advance!

Reproduction

StackBlitz link: https://stackblitz.com/edit/timepicker-scroll-strategy-issue?file=src%2Fmain.ts
Steps to reproduce:

1. Open the Timepicker dropdown (doesn't matter if you open it with the button or by clicking into the component)
2. Start scrolling on the page, and it will close the Timepicker dropdown
3. Try opening the Timepicker dropdown again, it won't open.

Expected Behavior

The Timepicker should open after closed by a scroll strategy.

Actual Behavior

The Timepicker cannot be opened after closed by a scroll strategy.

Environment

• Angular: 19.2.0
• CDK/Material: 19.2.1
• Browser(s): Chrome latest
• Operating System (e.g. Windows, macOS, Ubuntu): Windows

[crisbeto]

Nah you're using it correctly, I didn't account that the timepicker's internal state needs to be updated too 🤦

[laliconfigcat]

I checked it with the new version and it works fine. Thank you for your fast fixes.
I'm not sure if I understand it correctly, but I checked the PR and it seems to me that you changed the default behaviour from reposition to close in the timepicker (https://github.com/angular/components/pull/30561/files#diff-181a5d41b30a68e462036f83ecacf4675dd6ff0212e94bf7e4436e9f36b8b8bfL73). I didn't have to add my custom scroll strategy, and it worked by default.
I'm not sure if that was intentional or not.

[crisbeto]

Oh geez, good callout 🤦 it should be reposition, I temporarily switched it to close to reproduce the issue and missed to revert it.

[laliconfigcat]

Awesome. I'll prepare my code to add the custom strategy so it can work with the next ng release too.
By the way, do you know why the reposition is the default strategy in every component? As it can cause glitches with every component on large pages, I'm wondering why didn't you go with .close() instead of it. Of course, having the option to set the scroll strategy totally works for me, i'm just curious.