Skip to content

ConnectedOverlayDirective relies on binding order #3225

Closed
@tbosch

Description

@tbosch

Bug, feature request, or proposal:

Bug

What is the expected behavior?

The directive should work independent of the order in which the bindings are set.

What is the current behavior?

The directive relies on the fact that the origin input is set before the open property, as the open property has a setter that relies on origin to be filled.

What are the steps to reproduce?

Users won't, I hit this while creating the new view engine for Angular 2.

What is the use-case or motivation for changing an existing behavior?

Changing Angular without breaking material.

Which versions of Angular, Material, OS, browsers are affected?

At least current master.

Is there anything else we should know?

A solution might be to use ngOnChanges instead of a setter for open in ConnectedOverlayDirective.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions