Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: md-select direct options data wiring for better startup time #3277

Closed
mbellezi opened this issue Feb 24, 2017 · 3 comments
Closed

Comments

@mbellezi
Copy link

Bug, feature request, or proposal:

Proposal

What is the expected behavior?

For more the one hundred itens, md-select should not be slow.

What is the current behavior?

For 200 itens, the md-select startup time is 150ms on desktop and nearly 1s on mobile. Even with AOT is slow.

What are the steps to reproduce?

Create a md-select with 200 itens or more.

Is there anything else we should know?

The md-select options could be wired directly using one @input that takes one array of label/value objects. This could be used to speedup startup as one do not have process and iterate through the md-option array.

@kara
Copy link
Contributor

kara commented Feb 24, 2017

The select needs virtual repeat for long lists, which still hasn't been implemented. That should improve perf: #823. Closing this one as a dupe to track in the other one.

@kara kara closed this as completed Feb 24, 2017
@mbellezi
Copy link
Author

mbellezi commented Feb 28, 2017

I understand but there are two phases here. One is instantiate and parse all md-option components and the other is the render itself.
I'm proposing to bypass this first phase when you want a simple Label/value list. Why do all the processing to build a list of label/value pairs when you could (optionally) pass it in as a @input?
In my opinion, there is no need to always emulate the select tag behavior (option tags).

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants