Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gulp build tasks for examples #3518

Closed
jelbourn opened this issue Mar 8, 2017 · 4 comments · Fixed by #4064
Closed

Add gulp build tasks for examples #3518

jelbourn opened this issue Mar 8, 2017 · 4 comments · Fixed by #4064
Assignees
Labels
area: dev-infra Issue related to internal project infrastructure

Comments

@jelbourn
Copy link
Member

jelbourn commented Mar 8, 2017

We should build the examples as a component library similar to how we build the material library itself and include the build output in the bundle that's published to material2-docs-content.

@devversion would you be able to tackle this?

@jelbourn jelbourn added the area: dev-infra Issue related to internal project infrastructure label Mar 8, 2017
@devversion devversion self-assigned this Mar 9, 2017
@devversion
Copy link
Member

@jelbourn Sure. I just hope we can make the changes without interfering with #3443.

@jelbourn
Copy link
Member Author

jelbourn commented Apr 8, 2017

Coming back to this: we should use the same code for building both lib/ and examples/, where the only input needed should be the root directory.

@devversion
Copy link
Member

Yeah that's what I planned to do. Let's take a look at this next week.

devversion added a commit to devversion/material2 that referenced this issue Apr 12, 2017
* Publish the `material-examples` package in the `material2-docs-content` repository.

Fixes angular#3518.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: dev-infra Issue related to internal project infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants