Skip to content

Screenshot Testing - Firebase Functions #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devversion opened this issue Mar 20, 2017 · 1 comment · Fixed by #3732
Closed

Screenshot Testing - Firebase Functions #3686

devversion opened this issue Mar 20, 2017 · 1 comment · Fixed by #3732
Labels
area: dev-infra Issue related to internal project infrastructure feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@devversion
Copy link
Member

Talked to @tinayuangao about PR #3628.

Things need to be done after the PR is merged:

  • Moving the setLocalFilenames method into the Firebase Functions
  • Separating Firebase functions into different JS files (clarity)
  • Setting Github Status from Firebase Functions (using firebase config)

Some additional things I would really like

  • Making the Firebase "routes" more like a REST API.
    e.g upload/screenshots/${PR_NUMBER}/images
@devversion devversion added the area: dev-infra Issue related to internal project infrastructure label Mar 20, 2017
@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix code health labels Mar 21, 2017
@tinayuangao tinayuangao mentioned this issue Mar 23, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: dev-infra Issue related to internal project infrastructure feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(screenshot): Improve Firebase Functions for screenshot tests tinayuangao/material2
3 participants
@jelbourn @devversion @tinayuangao