Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD Toolbar height weird #3746

Closed
patrikx3 opened this issue Mar 23, 2017 · 9 comments
Closed

MD Toolbar height weird #3746

patrikx3 opened this issue Mar 23, 2017 · 9 comments

Comments

@patrikx3
Copy link

Please check my site:
https://pages.corifeus.tk/

When you size the browser width with a toolbar, it is correct, instead about the middle width it becomes too small.

Like toolbar:
width ~1920 - toolbar height = X
width ~889 toolbar height = 0.8 * X
width ~785 toolbar height = X

It should be the same, except maybe when width < 600.

Widest, height correct:
image

Middle, height it too narrow:
image

Narrow, height is correct:
image

@patrikx3
Copy link
Author

critical error:

@media (max-width: 960px) and (orientation: landscape) {
 .mat-toolbar {
     min-height: 48px;
 }
}
// Set the default height for the toolbar.
@include mat-toolbar-height($mat-toolbar-height-desktop);

@willshowell
Copy link
Contributor

You can see from #2157 that those numbers are coming from the Material spec for app bars.

Default heights:

Mobile Landscape: 48dp
Mobile Portrait: 56dp
Tablet/Desktop: 64dp

@patrikx3
Copy link
Author

ciao, chrome debian is not mobile landscape. still it changes the toolbar height.

@patrikx3
Copy link
Author

sent you 3 screenshots. they all desktop landscape. still it shrinks like it is a mobile landscape.

@patrikx3
Copy link
Author

sorry i sent you mobile screenshot, i send you a new 3 shots. same bug. sorry.

@patrikx3
Copy link
Author

Still it is the first one is once like this height, then smaller, then the first again, werid!!!
CIAO!

Full HD, toolbar as expected:
image

Resize browser, about middle , it is wrong, too small:
image

I bit smaller resize, now the toolbar height is correct:
image

@willshowell
Copy link
Contributor

Ahh it looks like this might have been fixed by #3312, which will be included in the next release.

@patrikx3
Copy link
Author

cool, thanks so much.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant