Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(toolbar): add responsive heights as per spec #2157

Merged
merged 2 commits into from
Dec 14, 2016

Conversation

devversion
Copy link
Member

@jelbourn Notice that the @media query for the landscape modes intentionally uses the $md-small breakpoint. See https://material.google.com/layout/responsive-ui.html#responsive-ui-breakpoints

Closes #2085.

* Adds media queries to dynamically adjust the height of the toolbar according to the specifications.
  https://material.google.com/layout/structure.html#structure-app-bar

Closes angular#2085.
@devversion devversion requested a review from jelbourn December 10, 2016 12:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2016
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 14, 2016
@jelbourn jelbourn merged commit 78d54fc into angular:master Dec 14, 2016
@lacolaco
Copy link
Contributor

lacolaco commented Dec 24, 2016

update(toolbar): cannot be a part of the changelog, but this change is very important as I think...

lacolaco pushed a commit to lacolaco/material2 that referenced this pull request Dec 24, 2016
lacolaco pushed a commit to lacolaco/material2 that referenced this pull request Dec 24, 2016
@devversion devversion deleted the chore/toolbar-responsive-heights branch December 24, 2016 09:41
kara pushed a commit that referenced this pull request Jan 5, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar height should adjust based on @media
4 participants