Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: bottom navigation #390

Closed
mikehaas763 opened this issue May 4, 2016 · 5 comments
Closed

feature request: bottom navigation #390

mikehaas763 opened this issue May 4, 2016 · 5 comments

Comments

@mikehaas763
Copy link

  • Do you want to request a feature or report a bug?

Request a feature + implement the feature: bottom navigation.

  • What is the current behavior?

Doesn't exist.

  • What is the expected behavior?

Hopefully, it will exist? 😄

  • What is the motivation / use case for changing the behavior?

I need to build a bottom based navigation for something I'm working on, so I figured I might as well build it and contribute it to material2

The component I'm referring to is https://www.google.com/design/spec/components/bottom-navigation.html#bottom-navigation-usage

Is there any appetite for this component in the library?

@jondejong
Copy link

Can you do this with just the toolbar and some flex layouts? Here's a quick example:

https://github.com/jondejong/ng2-md-bottom-nav-bar

@mikehaas763
Copy link
Author

mikehaas763 commented May 7, 2016

@kara I've started work on this, basically just boilerplate at this point for the component itself and the demo app. Is it beneficial to create a PR before it's ready (so others can see that it's being worked on, etc) or does that complicate the process?

@kara
Copy link
Contributor

kara commented May 7, 2016

The first step is to create a design doc (you can find example design docs linked in the README). Once we've agreed on an approach, generally the next step is a WIP pull request.

@jelbourn
Copy link
Member

jelbourn commented May 9, 2016

Going to track this via #408. If anyone plans on working on this, the first step is to comment on that PR stating your intent to implement, along with how you plan to approach it. The next step is to write a design document for the team to review (following our template). You can see the directory of existing design docs on our wiki.

@jelbourn jelbourn closed this as completed May 9, 2016
andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants