Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming mixins/variables massively duplicated in release output #3931

Closed
willshowell opened this issue Apr 6, 2017 · 3 comments · Fixed by #4174
Closed

Theming mixins/variables massively duplicated in release output #3931

willshowell opened this issue Apr 6, 2017 · 3 comments · Fixed by #4174
Assignees
@jelbourn @devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug? Proposal?

What is the current behavior?

In the output _theming.scss, there is massive duplication of the palettes and mixins.

The 756 KB file can be brought down to ~82 KB by removing the duplication.

What is the use-case or motivation for changing an existing behavior?

I don't really know/understand how big of deal this is. I guess it slows down npm download times and takes up 600 KB+ more disk space than required.

Related to #3776
@M-a-c
Copy link
Contributor

M-a-c commented Apr 6, 2017

I wonder if there is a way to just import and export the themes form there, instead of using gulp to just copy the contents over.

@jelbourn
Copy link
Member

jelbourn commented Apr 9, 2017

Looks like an issue with the scss bundling tool we're using. I filed an issue there: reactway/scss-bundle#16

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 9, 2017
@jelbourn jelbourn self-assigned this Apr 9, 2017
@willshowell willshowell mentioned this issue Apr 19, 2017
Closed
@devversion devversion self-assigned this Apr 19, 2017
devversion added a commit to devversion/material2 that referenced this issue Apr 20, 2017
@devversion
build: dedupe theming scss bundle
1fc9a3a 
* Updates to a more recent version of SCSS-bundle that has support for deduping. The dedupe process is very naive and only disallows importing a file multiple times.
* Switches to the programmatic API of `scss-bundle`
* Removes unused functions and imports / leftovers.

Fixes angular#3931
@devversion devversion mentioned this issue Apr 20, 2017
Merged
devversion added a commit to devversion/material2 that referenced this issue Apr 20, 2017
@devversion
build: dedupe theming scss bundle
281b732 
* Updates to a more recent version of SCSS-bundle that has support for deduping. The dedupe process is very naive and only disallows importing a file multiple times.
* Switches to the programmatic API of `scss-bundle`
* Removes unused functions and imports / leftovers.

Fixes angular#3931
kara pushed a commit that referenced this issue Apr 21, 2017
@devversion @kara
build: dedupe theming scss bundle (#4174)
7c81698 
Fixes #3931
@fxck fxck mentioned this issue Apr 26, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jelbourn jelbourn

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: dedupe theming scss bundle devversion/material2
4 participants
@jelbourn @M-a-c @devversion @willshowell