Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab body content with scrollbar #4035

Closed
rtrompier opened this issue Apr 11, 2017 · 5 comments · Fixed by #4062
Closed

Tab body content with scrollbar #4035

rtrompier opened this issue Apr 11, 2017 · 5 comments · Fixed by #4062
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@rtrompier
Copy link

Since beta-3, all the tabs content have a scrollbar.

Check the mat-tab-body-content class => height: 100%;
@rtrompier rtrompier changed the title Tab boy content with scrollbar Tab body content with scrollbar Apr 11, 2017
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Apr 11, 2017
@jelbourn
Copy link
Member

@crisbeto I noticed this on the docs site too

crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 12, 2017
@crisbeto
fix(tabs): unnecessary scrollbar if content has a margin
c33e4de 
Fixes the tabs having a scrollbar if their inner content has a margin. This seems to be a side-effect of angular#3162.

Fixes angular#4035.
@crisbeto crisbeto mentioned this issue Apr 12, 2017
Merged
jelbourn pushed a commit that referenced this issue Apr 17, 2017
@crisbeto @jelbourn
fix(tabs): unnecessary scrollbar if content has a margin (#4062)
7336bdc 
Fixes the tabs having a scrollbar if their inner content has a margin. This seems to be a side-effect of #3162.

Fixes #4035.
@naveedahmed1
Copy link

naveedahmed1 commented May 12, 2017 •
edited
Loading

In my case since beta-4, now when I switch the tabs it shows the scrollbar while the animations is in progress. If I unset height everything works fine.

.mat-tab-body-content{
    height:unset!important;
}

crisbeto added a commit to crisbeto/material2 that referenced this issue May 13, 2017
@crisbeto
fix(tabs): dynamic tab scrollbar showing while animating
9dfadae 
Fixes an issue that caused a scrollbar to be shown only while a tab inside a dynamic height tab group is animating.

Relates to angular#4035.
@crisbeto crisbeto mentioned this issue May 13, 2017
Merged
@jelbourn
Copy link
Member

@naveedahmed1 please open a new issue if you're encountering a new bug

@naveedahmed1
Copy link

Seems @crisbeto already have a pull request waiting to be merged regarding this issue, #4524 do I still need to open a new issue?

jelbourn pushed a commit that referenced this issue May 17, 2017
@crisbeto @jelbourn
fix(tabs): dynamic tab scrollbar showing while animating (#4524)
2a15cd7 
Fixes an issue that caused a scrollbar to be shown only while a tab inside a dynamic height tab group is animating.

Relates to #4035.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): unnecessary scrollbar if content has a margin crisbeto/material2
4 participants
@jelbourn @rtrompier @crisbeto @naveedahmed1