Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested <md-tab-group>s crash Angular #4277

Closed
oldchevy opened this issue Apr 26, 2017 · 3 comments · Fixed by #4315
Closed

Nested <md-tab-group>s crash Angular #4277

oldchevy opened this issue Apr 26, 2017 · 3 comments · Fixed by #4315
Assignees

Comments

@oldchevy
Copy link

oldchevy commented Apr 26, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Before this pull request animation behavior was working fine as intended:
fbfd032

What is the current behavior?

Nested <md-tab-group>s with more than two <md-tab>s crash the app. With two <md-tab>s the second tab is overlaid on top of the first.

What are the steps to reproduce?

Here is a plunker detailing the bug. The plunker is running on Angular v4.0.3:
https://plnkr.co/edit/qSZMIMlfSLIVcGkEzUQq

What is the use-case or motivation for changing an existing behavior?

It should be possible to nest tab groupings.

Which versions of Angular, Material, OS, browsers are affected?

Most recent, see PR referenced.

Is there anything else we should know?

@crisbeto
Copy link
Member

Thanks for the report, I'll re-check it. Before I reverted #2411 via fbfd032, I did verify against the old test case, that it was supposed to fix (it was actually crashing the entire tab), and the workaround was no longer necessary.

@crisbeto crisbeto self-assigned this Apr 26, 2017
@alexciesielski
Copy link

Dup #4271
Related #4255

(linking issues to close them more easily later)

crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 27, 2017
Fixes an animation error that gets thrown when nesting tab groups. It appears to be due to the animation not having a defined "from" style when going from `void` to something else.

Fixes angular#4277.
mmalerba pushed a commit that referenced this issue Apr 28, 2017
Fixes an animation error that gets thrown when nesting tab groups. It appears to be due to the animation not having a defined "from" style when going from `void` to something else.

Fixes #4277.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants