-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button should be capitalized by default per MD spec #4496
Comments
No, it shouldn't be set by default. As @jelbourn mentioned in #2637:
|
What @donroyco said. |
That makes sense. Thanks for the feedback. |
@donroyco @jelbourn The button used by md-snackbar ( |
@ccstevenson yes, that is unintentional and it should be removed. |
@jelbourn Can I make a PR for this? Or create a new 'issue' and file a PR in that one... |
PR would be great |
@ccstevenson @jelbourn PR on the way... #4567 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Button text should be in uppercase according to the material design spec. Should this rule be defaulted in the appropriate contexts in Angular Material?
What is the expected behavior?
https://material.io/guidelines/components/buttons.html#buttons-usage
What is the current behavior?
text is not capitalized
What are the steps to reproduce?
Any button in any sample
What is the use-case or motivation for changing an existing behavior?
Default behavior should follow the spec
Which versions of Angular, Material, OS, browsers are affected?
current version
Is there anything else we should know?
Here's an option to make it work on forms, cards and dialogs and excludes buttons in menus:
The text was updated successfully, but these errors were encountered: