Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure easing curves and shadows are on-spec #48

Closed
jelbourn opened this issue Jan 28, 2016 · 9 comments
Closed

Make sure easing curves and shadows are on-spec #48

jelbourn opened this issue Jan 28, 2016 · 9 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jelbourn
Copy link
Member

Current easing curves and shadows are pulled from Angular 1 version. We need to double check that these reflect the current state of the spec.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Jan 28, 2016
@jelbourn jelbourn added this to the alpha.1 milestone Jan 28, 2016
@bakgat
Copy link

bakgat commented Feb 17, 2016

In _shadows.scss this link is provided as documentation for shadows
http://google.com/design/spec/what-is-material/objects-in-3d-space.html

In the new spec the link should be http://www.google.com/design/spec/what-is-material/elevation-shadows.html

I think there are differences in shadows.
eg For raised buttons it states 2dp elevation, 8dp on active.

elevation diagram

@traviskaufman
Copy link
Contributor

@jelbourn jelbourn modified the milestones: alpha.2, alpha.1 Mar 17, 2016
traviskaufman added a commit to traviskaufman/material2 that referenced this issue Mar 22, 2016
This commit replaces `_shadows.scss` within `src/core/styles` with
`_elevation.scss`, according to the proposed design outlined
[here](https://goo.gl/Kq0k9Z). All components that were dependent on the
old shadows have been modified to use elevation. Note however that none
of the values in those old components have been changed; it's simply a
to the new API.

Part of angular#48.
traviskaufman added a commit to traviskaufman/material2 that referenced this issue Mar 24, 2016
This commit replaces `_shadows.scss` within `src/core/styles` with
`_elevation.scss`, according to the proposed design outlined
[here](https://goo.gl/Kq0k9Z). All components that were dependent on the
old shadows have been modified to use elevation. Note however that none
of the values in those old components have been changed; it's simply a
to the new API.

Part of angular#48.
jelbourn pushed a commit that referenced this issue Mar 25, 2016
This commit replaces `_shadows.scss` within `src/core/styles` with
`_elevation.scss`, according to the proposed design outlined
[here](https://goo.gl/Kq0k9Z). All components that were dependent on the
old shadows have been modified to use elevation. Note however that none
of the values in those old components have been changed; it's simply a
to the new API.

Part of #48.

Closes #222
@jelbourn jelbourn modified the milestones: alpha.2, alpha.3 Apr 4, 2016
@jelbourn
Copy link
Member Author

Done for elevation.
@traviskaufman did you have any feedback on easing curves, or should we be able to grab what we need from the spec?

@jelbourn jelbourn modified the milestones: alpha.5, alpha.3 Apr 21, 2016
@jelbourn jelbourn modified the milestones: before beta, alpha.5 May 23, 2016
@jelbourn jelbourn removed this from the before beta milestone Nov 4, 2016
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P2 The issue is important to a large percentage of users, with a workaround labels Nov 4, 2016
@jelbourn
Copy link
Member Author

jelbourn commented Nov 4, 2016

@mmalerba the task here is to make sure all the timings and curves we're using are on-spec and shared between components. This is a lower-priority item for beta.

@mmalerba mmalerba closed this as completed Nov 8, 2016
@mmalerba mmalerba reopened this Nov 8, 2016
@mmalerba
Copy link
Contributor

mmalerba commented Nov 8, 2016

Sorry, didn't mean to close this. Interesting part of the spec related to animations is dynamic durations: https://material.googleplex.com/motion/duration-easing.html#duration-easing-dynamic-durations (the idea that the duration changes based on the size of your device). Is this something we want to include in our implementation?

@jelbourn
Copy link
Member Author

jelbourn commented Nov 8, 2016

I hadn't seen that before. I'd consider that a "nice-to-have" for now, something we can refine later.

@mmalerba
Copy link
Contributor

pr for shadows: #1857

still need to do animations

@jelbourn jelbourn closed this as completed Apr 9, 2017
@thw0rted
Copy link

Hello from the future! I don't know if anybody is still subscribed, but I came here to find out how material2 handles changing its animation timing based on device type (as the spec requires) -- looks like maybe the answer at this time is that you don't?

Should I open a new ticket to bring timing in line with the spec or would it be better to reopen this one? I am still trying to figure out how to actually decide what timing to use in my own animations. Best I have right now is:

  • if touch isn't supported, use desktop timing (150-200ms)
  • otherwise, find the smaller of window.screen.height or window.screen.width and divide by window.devicePixelRatio to get an approximate DP size
  • Compare DP size to an arbitrary cutoff (say, 6 in * 96 DP/in) to decide if we use phone timings (~300ms) or tablet timings (~390ms).

It's far from perfect but I don't know if we can get any better information to make the decision.

andrewseguin pushed a commit to andrewseguin/components that referenced this issue Oct 15, 2018
* make sidenav shell look like mocks

* toolbar shadow

* fix lint

* category list styles

* component list styles
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants