-
Notifications
You must be signed in to change notification settings - Fork 6.8k
SnackBarRef component instance ? #6252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Agreed that it would be nice to be consistent with |
Oops, i perhaps haven't updated to the latest version, my bad. It was not the central point though ;) |
instance is renamed to componentInstance to be consistent with other dialogs Closes angular#6252
instance is renamed to componentInstance to be consistent with other dialogs Closes angular#6252
instance is renamed to componentInstance to be consistent with other dialogs Closes angular#6252
BREAKING CHANGE: Renamed instance to componentInstance to be consistent with other dialogs Closes angular#6252
BREAKING CHANGE: Renamed variable instance to componentInstance to be consistent with other dialogs Closes angular#6252
Closing this since, after releasing 5.0.0, we aren't making any more breaking API changes. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Feature request
What is the expected behavior?
Having a standard for the instance reference and sharing data.
What is the current behavior?
To get the component instance of a SnackBarRef, the attribute is "instance".
To get the component instance of a DialogRef, the attribute is "componentInstance". Besides, in the documentation we can see a method to share data directly has been implemented, it's not the case for SnackBarRef.
What is the use-case or motivation for changing an existing behavior?
I think having a standard for these components "with reference" would be clearer for the user.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest of each.
The text was updated successfully, but these errors were encountered: