-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Not possible to open second dialog if NoopAnimationsModule is used #6719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (`done` callback fires before `start`), which causes the `_isAnimating` property to be set to `true` while the animation already finished. Fixes angular#6719
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished. @crisbeto Not too happy how the tests ended up. Fixes angular#6719
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished. @crisbeto Not too happy how the tests ended up. Fixes angular#6719
Do you have any ETA on this ? A side effect of this issue is that MdDialog return the wrong MdDialogRef (from the already opened dialog) instead of the one of the new (but not opened) dialog. |
@TomDemulierChevret No ETA for this, but the PR that fixes the issue is ready for merge. |
@devversion Nice. |
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished. @crisbeto Not too happy how the tests ended up. Fixes angular#6719
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished. @crisbeto Not too happy how the tests ended up. Fixes angular#6719
I'm wondering why this issue still happens on EDGE and IE11 even if I import BrowserAnimationsModule? |
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished. @crisbeto Not too happy how the tests ended up. Fixes angular#6719
We are facing the same issue. Opening nested dialog on iOS with BrowserAnimationsModule does not work. the logic inside the open dialog is below. openDialog() { Also, when using NoopAnimationsModule, the dialog.open needs to wrapped inside setTimeout to work on iOS devices. Kindly assist |
With SHA 36f708c, second dialogs can be only opened if the first dialog finished animating. Due to the recent update to Angular 4.3, the animation trigger callbacks are firing in a wrong order (done callback fires before start), which causes the _isAnimating property to be set to true while the animation already finished. @crisbeto Not too happy how the tests ended up. Fixes angular#6719
Any workaround for this until the PR i merged and released? |
This issue getting blocker for us. Any update or workaround?? |
An update on this would be appreciated. |
It is pretty sad that no one will even give an update on this. Last response 22 days ago. |
I think they are working on it. See this pull request . |
Hi, I solved it by first calling the MatDialog.getDialogById() with the id of the first MatDialogRef, if it returns |
This issue has been fixed with #8051 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
It should be possible to open multiple dialogs even if NoopAnimationsModule is used. It works if BrowserAnimationsModule is used.
What is the current behavior?
If you try to open a second dialog nothing happens
What are the steps to reproduce?
http://plnkr.co/edit/K8SwE9LJeVnVleUic8X3?p=preview
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular@4.3.4, angular-material@beta-10
Is there anything else we should know?
This pull request looks like a suspect: #5769
The text was updated successfully, but these errors were encountered: