-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(rc5 and alpha7)url_resolver.js:238Uncaught TypeError: uri.match is not a function #974
Comments
I second this. Having the same problem, using the new angular-cli webpack release. |
This seems to be related to how it's dealing with the moduleId, if you comment out the moduleId of the components, they compile without error. |
It appears this pull request will fix this issue angular/angular@f54f9ef. You guys can close this if you want to as it appears to be an angular compiler issue and not specific to material |
qdouble, that pull request does fix the "TypeError: uri.match is not a function" problem, but results in another error (BaseException) for me with the following message:
Not sure if it's related, and if it's not, happy to open a new issue. |
@FoodBuster that's an unrelated error, it saying 'md-ripple-trigger' isn't defined on the MdButton directive/component. |
@qdouble Thanks, got it working. |
> Removes the module ids of the component metadata. > Since the templates and styles are now inlined, the module id has become unnecessary and > can cause unexpected issues This also fixes angular#974 in meanwhile.
> Removes the module ids of the component metadata. > Since the templates and styles are now inlined, the module id has become unnecessary and > can cause unexpected issues This also fixes #974 in meanwhile.
I have released an |
Thanks |
Maybe I'm doing something wrong, but simply upgrading to alpha.7-2 doesn't fix for me. |
@neclepsio it's possible another component or 3rd party plugin in your application has a moduleId. |
@qdouble I don't think so. I'm just using BrowserModule, FormsModule and several Ms...Module. How can I check? Thank you. |
@qdouble You were right! My own app.component had a moduleId! |
@jelbourn Your fix in alpha.7-2 works for me, but it appears the problem was reintroduced somewhere before alpha.7-9. Can you try to fix it in again? |
@zackporter92 this caused it to pop back up: #1101 |
@qdouble interesting. So we should just stick to 7-2 if we have that problem? |
For temporary workaround, you can put this as a preloader in your webpack config, just npm install string-replace-loader
or on @angular/compiler/src/url_resolver.js line 238, you can change |
I get same error. I am using final release Angular2. It work when I remove "moduleId: module.id" from contact component. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm refiling for this issue: #963 as it was not resolved in alpha 7. I've tested it on two fresh seed projects and the error still occurs, so it should be a common problem with Webpack at least, not sure if this shows up in a SystemJS build or not.
The text was updated successfully, but these errors were encountered: