-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtual-scroll: Fixes scroll gap with autosize #11195
Conversation
|
||
// once we hit the bottom, we need to resample our range | ||
// based on the items in view so we don't create a gap | ||
if (renderedRange.end === viewport.getDataLength()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know that this fixes it, probably will want to find a way to do it that doesn't lose our size info though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, I suspected this was more of a starting point rather than the actual fix.
we need to see the reference of this issue in the other [root] ticket. Tag #823 |
@amcdnl Will this fix the space that we get when used inside mat-select ?
https://stackblitz.com/edit/angular-h4xptu-dgjd87?file=app/select-reset-example.html ? |
I'm the one primarily working on it, but I've been busy with other things lately. I'll have some time to work on it more after the 7.0 release |
Ok thanks for the update. Appreciate it. Good luck for the major release. |
Hi @amcdnl! This PR has merge conflicts due to recent upstream merges. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR fixes the scroll gap that occurs at the end of a auto-sized scrolled. This resets the range and creates a new sample based on whats in view so we aren't 'predicting' the size and ending up with a gap.
Demo of issue: https://stackblitz.com/edit/angular-soc77e