Skip to content

refactor: remove deprecated injector.get signature usages #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2018
Merged

refactor: remove deprecated injector.get signature usages #11264

merged 1 commit into from
May 11, 2018

Conversation

crisbeto
Copy link
Member

Removes a few usages of a deprecated signature of Injector.get.

@crisbeto
refactor: remove deprecated injector.get signature usages
a4ad995 
Removes a few usages of a deprecated signature of `Injector.get`.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 10, 2018
jelbourn
jelbourn approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 10, 2018
@CaerusKaru CaerusKaru mentioned this pull request May 10, 2018
Closed
@jelbourn jelbourn merged commit 72e5196 into angular:master May 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot