feat(select): allow for option sorting logic to be customized #11890
Conversation
googlebot
added
the
cla: yes
src/lib/select/select.ts
Outdated
| * Function used to sort the values inside a select in multiple mode. | ||
| * Follows the same logic as `Array.prototype.sort`. | ||
| */ | ||
| @Input() sortPredicate: (a: MatOption, b: MatOption, options: MatOption[]) => number = |
There was a problem hiding this comment.
"Predicate" isn't the right term, since a predicate is something that always returns a boolean value. I think sortComparator would be more accurate
There was a problem hiding this comment.
TIL. I've renamed it to sortComparator.
crisbeto
force-pushed
the
11871/select-sort-predicate
branch
from
a3c404f to
5282b2b
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
Looks like this has failures on travis now |
crisbeto
force-pushed
the
11871/select-sort-predicate
branch
from
5282b2b to
ac5913e
Compare
Adds an input for a `sortComparator` to `mat-select`. The new input allows consumers to override the logic that `mat-select` uses to sort its values. Fixes angular#11871.
crisbeto
force-pushed
the
11871/select-sort-predicate
branch
from
ac5913e to
0d3ae16
Compare
|
Fixed the test failures. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds an input for a
sortComparatortomat-select. The new input allows consumers to override the logic thatmat-selectuses to sort its values.Fixes #11871.