Skip to content

feat(drag-drop): support sorting items horizontally #12104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josephperrott merged 1 commit into from
Jul 9, 2018
Merged

feat(drag-drop): support sorting items horizontally #12104

josephperrott merged 1 commit into from
Jul 9, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 8, 2018

  • Adds support for sorting items horizontally.
  • Fixes some tests going into an infinite loop if they fail.
  • Fixes the drag item's directionality not propagating to its preview.

Fixes #12066.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 8, 2018
@crisbeto crisbeto mentioned this pull request Jul 8, 2018
Closed
@crisbeto crisbeto force-pushed the 12066/drag-horizontal branch from a79069c to 24cb0bd Compare July 8, 2018 11:58
josephperrott
josephperrott approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: master only labels Jul 9, 2018
@crisbeto crisbeto force-pushed the 12066/drag-horizontal branch from 24cb0bd to f59d9b8 Compare July 9, 2018 17:39
@crisbeto
feat(drag-drop): support sorting items horizontally
06af0e1 
* Adds support for sorting items horizontally.
* Fixes some tests going into an infinite loop if they fail.
* Fixes the drag item's directionality not propagating to its preview.

Fixes angular#12066.
@crisbeto crisbeto force-pushed the 12066/drag-horizontal branch from f59d9b8 to 06af0e1 Compare July 9, 2018 17:42
@josephperrott josephperrott merged commit a410865 into angular:master Jul 9, 2018
josephperrott pushed a commit that referenced this pull request Jul 9, 2018
@crisbeto @josephperrott
feat(drag-drop): support sorting items horizontally (#12104)
3984fe9
@crisbeto crisbeto mentioned this pull request Jul 9, 2018
Closed
@pas2al pas2al mentioned this pull request Jul 11, 2018
Closed
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
@crisbeto @victoriaaa234
feat(drag-drop): support sorting items horizontally (#12104)
9e19948
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Drag & Drop - Doesn't Seem to Be Functioning Correctly With Horizontally Stacked Items

4 participants

@crisbeto @josephperrott @jelbourn @googlebot