Skip to content

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 9, 2018

No description provided.

@mmalerba mmalerba requested a review from jelbourn July 9, 2018 20:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 9, 2018
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
@ngbot
Copy link

ngbot bot commented Jul 9, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn
Copy link
Member

jelbourn commented Jul 9, 2018

LGTM, just needs a name

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jul 9, 2018
@mmalerba mmalerba merged commit e1fd13a into angular:master Jul 9, 2018
mmalerba added a commit that referenced this pull request Jul 9, 2018
* update changelog for 6.3.3

* add release name
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
* update changelog for 6.3.3

* add release name
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants