fix(schematics): tree schematic not working #12281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
rafaelss95
reviewed
Jul 19, 2018
| return node.expandable; | ||
| }; | ||
|
|
||
| /** Get whether the node has children or not. */ | ||
| hasChild(index: number, node: FlatTreeNode){ |
There was a problem hiding this comment.
can we have a space before {?
There was a problem hiding this comment.
Good catch. Note that I just moved that already existing code one block up.
jelbourn
approved these changes
Jul 20, 2018
jelbourn
added
pr: lgtm
target: patch
* Fixes that the new `tree` schematic is not working when added to an Angular app. Since one `FileNode` does not have the required `type` property, the TS compiler will complain about wrongly assigning the example data to the `DataSource`.
devversion
force-pushed
the
fix/schematics-tree-schematic-not-working
branch
from
45e067f to
b700c4e
Compare
devversion
added
target: master only
and removed
target: patch
|
@jelbourn Done. I think it should be |
|
Ah, yeah then. For some reason I thought it had been there for a while. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the new
treeschematic is not working when added to an Angular app. Since oneFileNodedoes not have the requiredtypeproperty, the TS compiler will complain about wrongly assigning the example data to theDataSource.Also makes it more obvious what
interfaceis doing. Right now, at first glance, I was pretty much confused byTreeNodeandFileNodeand what the flattener is actually doing.It should be a easy-to-use and easy-to-understand quick-start schematic.
Actual error in a new NG app
