Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidenav): move @Input to getter/setter instead of private field #1245

Closed
wants to merge 1 commit into from

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Sep 15, 2016

This breaks AOT compile since the generated factory tries to set the private field.

I'm unsure of the ramifications of change detection setting opened via the setter, which will call toggle() where it didn't before - someone who understands the code should look at that.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2016
@jelbourn
Copy link
Member

Closing this since the fix is already captured in #1225

@jelbourn jelbourn closed this Sep 15, 2016
@alxhub alxhub deleted the fix-md-sidenav-input branch May 7, 2019 20:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants