Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): allow for non-colored flat button #12550

Merged
merged 1 commit into from
Aug 7, 2018
Merged

fix(button): allow for non-colored flat button #12550

merged 1 commit into from
Aug 7, 2018

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Aug 6, 2018 •
edited
Loading

Fixes #12449

@josephperrott josephperrott requested a review from jelbourn August 6, 2018 16:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2018
jelbourn
jelbourn approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Aug 6, 2018
@josephperrott josephperrott merged commit 8c08bb1 into angular:master Aug 7, 2018
@josephperrott josephperrott deleted the button-flat-color branch August 7, 2018 20:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-primary being applied to flat button by default
3 participants
@josephperrott @jelbourn @googlebot