fix(checkbox, slide-toggle): no margin if content is projected #12973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually if the label of the checkbox or slide-toggle is empty, we remove the margin between label container and thumb/check because otherwise there would be too much spacing. Currently if developers use a component inside of the checkbox or slide-toggle in order to render the label, the margin is accidentally removed and the label looks misplaced. This is because the `cdkObserveContent` event runs outside of the `NgZone` and no change detection round _checks_ the checkbox or slide-toggle. Fixes angular#4720
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 4, 2018
| // Instead of going back into the zone in order to trigger a change detection which causes | ||
| // *all* components to be checked (if explicitly marked or not using OnPush), we only trigger | ||
| // an explicit change detection for the checkbox view and it's children. | ||
| this._changeDetectorRef.detectChanges(); |
There was a problem hiding this comment.
Can we add a test for this, even if that test is doing getComputedStyle?
mmalerba
approved these changes
Sep 5, 2018
josephperrott
approved these changes
Sep 10, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually if the label of the checkbox or slide-toggle is empty, we remove the margin between label container and thumb/check because otherwise there would be too much spacing. Currently if developers use a component inside of the checkbox or slide-toggle in order to render the label, the margin is accidentally removed and the label looks misplaced.
This is because the
cdkObserveContentevent runs outside of theNgZoneand no change detection round checks the checkbox or slide-toggle.Simple demo
Why
detectChangesand not ngZone.run()?Creating a new zone fork e.g.
ngZone.run(() => {})causes theonMicrotaskEmptyto trigger and dirty check all components which are explicitly "markForChecked or not usingOnPush`.Since
cdkObserveContentemits an @output() the checkbox will be automatically marked for check, but due to emitting outside ofNgZone, just no change detection will run becauseonMicrotaskEmptydoesn't fire after callback.So the best solution for now is:
Use explicitly
detectChangesbecause it would then just check the checkbox and it's children. Since we know that only the margin class binding needs to be updated, this is way better than triggering a global dirty-check.If we would use
ngZone.run(() => {}it would cause Angular to check all components in the application which are marked for check or not usingOnPush(which is very likely)Fixes #4720