feat(md-progress-bar): Create initial ProgressBar implementation. #130

josephperrott · 2016-03-04T14:32:15Z

googlebot · 2016-03-04T14:32:18Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

googlebot · 2016-03-04T14:32:18Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

josephperrott · 2016-03-04T14:34:32Z

I signed it!

jelbourn · 2016-03-07T22:34:34Z

docs/dart/writing-compatible-typescript.md

@@ -43,3 +43,6 @@ Here's a list of gotchas to keep in mind when writing TypeScript code that will
 * **Lambdas need to abide to the type required.** Meaning that if a function requires a function that takes one argument, the lambda cannot be `() => {}`. Use `_` for temporary parameters. This is notable in Promises.
 * **Dynamic return values fat arrows can't return non-primitive types without casting.** For example, a fat arrow that return a promise (or Future) generates a warning if using directly, like so: `promiseA.then(() => promiseB)`. In this case simply using a block works as expected; `promiseA.then(() => { return promiseB; })`.
 * **Dart does not have [generic methods](http://www.typescriptlang.org/Handbook#generics)** ([issue](https://github.com/dart-lang/sdk/issues/254)).
+* **Dart does not have destructuring** but it does have a [proposal](https://github.com/dart-lang/dart_enhancement_proposals/issues/24) for it.
+* **Dart does not support type aliases.** Code like `type Nop = () => void` will not compile.
+* **Dart does not support [tagged template literals](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#Tagged_template_literals)**.


Looks like you need to rebase again, since these changes came from an earlier commit.

jelbourn · 2016-03-07T23:36:53Z

Finished first pass of comments.

hansl · 2016-03-08T00:16:21Z

src/components/progress-bar/progress-bar.scss

+}
+
+
+/** Animations for indeterminate and query mode. */


Could you point to the resource you used to get those percentage for animations? They seem like magic numbers without context.

jelbourn · 2016-03-10T16:36:28Z

src/components/progress-bar/progress-bar.scss

+
+/** Animations for indeterminate and query mode. */
+// Primary indicator.
+@keyframes md-progress-bar-primary-indeterminate-translate {


Is it possible at all to go into more detail about what each keyframe animation is actually doing?
Perhaps @traviskaufman could add more info

Sure can 😃

The indeterminate state is essentially made up of two progress bars, one primary (the one that is shown in both the determinate and indeterminate states) and one auxiliary, which essentially mirrors the primary progress bar in appearance but is only shown to assist with the indeterminate animations.

Given the mocks for the indeterminate APIs, you essentially have 4 animations being performed in tandem:

Keyframe Block Description

primary-indeterminate-translate Translation of the primary progressbar across the screen

primary-indeterminate-scale Scaling of the primary progressbar as it's being translated across the screen

auxiliary-indeterminate-translate Translation of the auxiliary progressbar across the screen

auxiliary-indeterminate-scale Scaling of the auxiliary progressbar as it's being translated across the screen

Because two different transform animations need to be applied at once, the translation is applied to the outer element and the scaling is applied to the inner element, which provides the illusion necessary to make the animation work.

added. I just copied the description you gave into the comment.

googlebot · 2016-03-16T20:09:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2016-03-16T20:09:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

jelbourn · 2016-03-17T18:30:28Z

src/components/progress-bar/progress-bar.ts

+   *
+   * Defaults to zero. Mirrored to aria-valuenow.
+   */
+  @Input('value')


The @Input() decorator should go on the getter, otherwise angular is going to directly set the private property (and not use the setter).

Not sure I understand what you are saying here.

I dont think it makes sense to put @Input on a getter.

It currently is:

@Input('value') _value: number = 0; @HostBinding('attr.aria-valuenow') get value_() { return this._value; }

It should be

private _value: number = 0; ... @Input() get value(): number { ... } set value(v: number) { ... }

When the @Input is on the private member, the setter is not called when Angular updates value, which isn't what you want. Angular is smart enough to know that putting @Input on a getter or a setter means to simply treat that as the bound property.

jelbourn · 2016-03-22T01:16:46Z

Needs a fresh rebase

josephperrott · 2016-04-08T17:27:31Z

Rebased, PTAL

googlebot · 2016-04-08T19:50:56Z

CLAs look good, thanks!

googlebot · 2016-04-08T19:50:56Z

CLAs look good, thanks!

jelbourn · 2016-04-08T20:16:18Z

LGTM

angular-automatic-lock-bot · 2019-09-05T23:02:05Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 4, 2016

hansl force-pushed the master branch from 4bfcf8a to 3cd3c6e Compare March 4, 2016 16:14

jelbourn reviewed Mar 7, 2016
View reviewed changes

hansl reviewed Mar 8, 2016
View reviewed changes

josephperrott added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 10, 2016

jelbourn reviewed Mar 10, 2016
View reviewed changes

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 16, 2016

jelbourn reviewed Mar 17, 2016
View reviewed changes

googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 22, 2016

jelbourn removed the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Mar 22, 2016

googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Apr 8, 2016

jelbourn added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 8, 2016

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 8, 2016

googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 8, 2016

jelbourn added pr: lgtm and removed pr: needs review labels Apr 8, 2016

feat(md-progress-bar): Create initial ProgressBar implementation.

79e6d1c

jelbourn merged commit c640f0c into angular:master Apr 8, 2016

josephperrott deleted the bar-only branch April 12, 2016 22:21

andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018

docs(list): fix list example (angular#130)

c791312

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(md-progress-bar): Create initial ProgressBar implementation. #130

feat(md-progress-bar): Create initial ProgressBar implementation. #130

josephperrott commented Mar 4, 2016

googlebot commented Mar 4, 2016

googlebot commented Mar 4, 2016

josephperrott commented Mar 4, 2016

jelbourn Mar 7, 2016

jelbourn commented Mar 7, 2016

hansl Mar 8, 2016

josephperrott Mar 10, 2016

jelbourn Mar 10, 2016

traviskaufman Mar 10, 2016

josephperrott Mar 16, 2016

googlebot commented Mar 16, 2016

googlebot commented Mar 16, 2016

jelbourn Mar 17, 2016

josephperrott Mar 22, 2016

jelbourn Mar 22, 2016

jelbourn commented Mar 22, 2016

josephperrott commented Apr 8, 2016

googlebot commented Apr 8, 2016

googlebot commented Apr 8, 2016

jelbourn commented Apr 8, 2016

angular-automatic-lock-bot bot commented Sep 5, 2019

Keyframe Block	Description
`primary-indeterminate-translate`	Translation of the primary progressbar across the screen
`primary-indeterminate-scale`	Scaling of the primary progressbar as it's being translated across the screen
`auxiliary-indeterminate-translate`	Translation of the auxiliary progressbar across the screen
`auxiliary-indeterminate-scale`	Scaling of the auxiliary progressbar as it's being translated across the screen

feat(md-progress-bar): Create initial ProgressBar implementation. #130

feat(md-progress-bar): Create initial ProgressBar implementation. #130

Conversation

josephperrott commented Mar 4, 2016

googlebot commented Mar 4, 2016

googlebot commented Mar 4, 2016

josephperrott commented Mar 4, 2016

Choose a reason for hiding this comment

jelbourn commented Mar 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Mar 16, 2016

googlebot commented Mar 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jelbourn commented Mar 22, 2016

josephperrott commented Apr 8, 2016

googlebot commented Apr 8, 2016

googlebot commented Apr 8, 2016

jelbourn commented Apr 8, 2016

angular-automatic-lock-bot bot commented Sep 5, 2019