Skip to content

feat(material/dialog): add the ability to control the animation duration #13466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

feat(material/dialog): add the ability to control the animation duration #13466

merged 1 commit into from
Mar 14, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 6, 2018

Since the dialog animation is on the MatDialogContainer, consumers aren't able to disable the animation. These changes add properties to the dialog config that allow consumers to set the duration of the dialog's enter and exit animations.

Fixes #3616.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Oct 6, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner October 6, 2018 08:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 6, 2018
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch from a8e5e31 to 1dead0f Compare October 6, 2018 08:47
jelbourn
jelbourn approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 8, 2018
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 19, 2018
@crisbeto
feat(experimental/dialog): add the ability to control the animation d…
7b315f7 
…uration

For keeping parity with the Material dialog (angular#13466), adds the ability for consumers to configure the animation duration of the dialog.
@crisbeto crisbeto mentioned this pull request Oct 19, 2018
Merged
@josephperrott josephperrott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 19, 2018
@josephperrott
Copy link
Member

Caretaker Note: Should be merged with #13694 as they are paired together.

@ngbot
Copy link

ngbot bot commented Nov 3, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

vivian-hu-zz pushed a commit that referenced this pull request Nov 10, 2018
@crisbeto @vivian-hu-zz
feat(experimental/dialog): add the ability to control the animation d…
6136ee7 
…uration (#13694)

For keeping parity with the Material dialog (#13466), adds the ability for consumers to configure the animation duration of the dialog.
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch from 1dead0f to b933fc1 Compare November 17, 2018 14:03
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label May 30, 2019
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch from b933fc1 to 8735035 Compare June 10, 2019 19:49
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch 2 times, most recently from 15a1d63 to 1cb94b5 Compare September 22, 2019 17:28
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch 2 times, most recently from bea7474 to e0cd1ac Compare December 25, 2019 14:25
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch from e0cd1ac to c678d2d Compare February 25, 2020 21:43
@devversion devversion mentioned this pull request May 26, 2020
Open
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto mentioned this pull request Nov 4, 2021
Open
@liesahead
Copy link

Is this is going to be merged?

@lansana
Copy link

lansana commented Nov 8, 2021

+1 would love to see this merged as well

@crisbeto crisbeto removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Nov 9, 2021
@crisbeto crisbeto changed the title feat(dialog): add the ability to control the animation duration feat(material/dialog): add the ability to control the animation duration Nov 9, 2021
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Nov 9, 2021
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch from c678d2d to 7b8856a Compare November 9, 2021 08:22
@crisbeto crisbeto requested review from andrewseguin and a team as code owners November 9, 2021 08:22
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch 3 times, most recently from 209fff9 to 28465be Compare November 10, 2021 11:59
@devversion devversion removed the request for review from a team November 10, 2021 17:15
@Splaktar Splaktar mentioned this pull request Dec 2, 2021
Closed
1 task
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch 2 times, most recently from 36aeca8 to 0b31649 Compare March 12, 2022 10:08
@crisbeto
feat(material/dialog): add the ability to control the animation duration
a6cea11 
Since the dialog animation is on the `MatDialogContainer`, consumers aren't able to disable the animation. These changes add properties to the dialog config that allow consumers to set the duration of the dialog's enter and exit animations.

Fixes angular#3616.
@crisbeto crisbeto force-pushed the 3616/dialog-animation-duration branch from 0b31649 to a6cea11 Compare March 12, 2022 10:37
@crisbeto crisbeto merged commit 8ef3125 into angular:master Mar 14, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 25, 2022
Closed
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
@crisbeto @forsti0506
feat(material/dialog): add the ability to control the animation durat…
868bb3d 
…ion (angular#13466)

Since the dialog animation is on the `MatDialogContainer`, consumers aren't able to disable the animation. These changes add properties to the dialog config that allow consumers to set the duration of the dialog's enter and exit animations.

Fixes angular#3616.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to turn off animation of dialog enter/exit
9 participants
@crisbeto @josephperrott @liesahead @lansana @jelbourn @googlebot @zarend @mmalerba @andrewseguin