fix(menu): unable to set icon color dynamically #14161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes not being able to set the color of a `mat-icon` inside a `mat-menu-item` dynamically. Fixes angular#14151.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto this results in a very high specificity rule, is there a way we can do it without increasing the specificity so much? (there seems to be some g3 tests I missed that are failing because of this) |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 5, 2018
In angular#14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
mmalerba
pushed a commit
that referenced
this pull request
Dec 5, 2018
In #14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
mmalerba
pushed a commit
that referenced
this pull request
Dec 10, 2018
Fixes not being able to set the color of a `mat-icon` inside a `mat-menu-item` dynamically. Fixes #14151.
mmalerba
pushed a commit
that referenced
this pull request
Dec 10, 2018
In #14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
Fixes not being able to set the color of a `mat-icon` inside a `mat-menu-item` dynamically. Fixes angular#14151.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
In angular#14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not being able to set the color of a
mat-iconinside amat-menu-itemdynamically.Fixes #14151.